Re: [PATCH] hid: usbhid: hiddev.c: fix checkpatch.pl errors

2017-02-28 Thread Benjamin Tissoires
Hi, well, not to undermine your work, I am not a big fan of this kind of patches. Yes, it's nice to follow checkpatch, but on some rare case, we just ignore the warning because the end result would be too ugly (I haven't read the patch, so I am not judging how you solved the issues raised here

Re: [PATCH] hid: usbhid: hiddev.c: fix checkpatch.pl errors

2017-02-28 Thread Benjamin Tissoires
Hi, well, not to undermine your work, I am not a big fan of this kind of patches. Yes, it's nice to follow checkpatch, but on some rare case, we just ignore the warning because the end result would be too ugly (I haven't read the patch, so I am not judging how you solved the issues raised here

[PATCH] hid: usbhid: hiddev.c: fix checkpatch.pl errors

2017-02-26 Thread Avraham Shukron
- Extracted assignments out of 'if' statements - Removed unnecessary spaces - Broke long lines - Added empty lines after declarations Signed-off-by: Avraham Shukron --- drivers/hid/usbhid/hiddev.c | 51 ++--- 1 file changed, 34

[PATCH] hid: usbhid: hiddev.c: fix checkpatch.pl errors

2017-02-26 Thread Avraham Shukron
- Extracted assignments out of 'if' statements - Removed unnecessary spaces - Broke long lines - Added empty lines after declarations Signed-off-by: Avraham Shukron --- drivers/hid/usbhid/hiddev.c | 51 ++--- 1 file changed, 34 insertions(+), 17