Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

2019-03-18 Thread Richard Weinberger
Am Montag, 18. März 2019, 09:41:28 CET schrieb Colin Ian King: > On 17/03/2019 23:49, Richard Weinberger wrote: > > Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King: > >> From: Colin Ian King > >> > >> The function link_file declaration in the header file has the order > >> of the two arg

Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

2019-03-18 Thread Walter Harms
Hi, Colin is obvously right with that. But my guess is that the error occured because the pattern (from, to) is brocken here. Also Maybe the maintainer can fix that. just my 2 cents, re, wh Am 18.03.2019 00:09, schrieb Colin King: > From: Colin Ian King > > The function link_file declarati

Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

2019-03-18 Thread Colin Ian King
On 17/03/2019 23:49, Richard Weinberger wrote: > Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King: >> From: Colin Ian King >> >> The function link_file declaration in the header file has the order >> of the two arguments (from, to) swapped when compared to the definition >> arguments of (

Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

2019-03-17 Thread Richard Weinberger
Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King: > From: Colin Ian King > > The function link_file declaration in the header file has the order > of the two arguments (from, to) swapped when compared to the definition > arguments of (to, from). Fix this by swapping them around to match

[PATCH] hostfs: fix mismatch between link_file definition and declaration

2019-03-17 Thread Colin King
From: Colin Ian King The function link_file declaration in the header file has the order of the two arguments (from, to) swapped when compared to the definition arguments of (to, from). Fix this by swapping them around to match the definition. This error predates the git history, so no idea whe