Re: [PATCH] hrtimer: annotate lockless access to timer->base

2019-10-13 Thread Eric Dumazet
On Tue, Oct 8, 2019 at 10:32 AM Eric Dumazet wrote: > > Followup to commit dd2261ed45aa ("hrtimer: Protect lockless access > to timer->base") > > lock_hrtimer_base() fetches timer->base without lock exclusion. > > Compiler is allowed to read timer->base twice (even if considered dumb) > and we

[PATCH] hrtimer: annotate lockless access to timer->base

2019-10-08 Thread Eric Dumazet
Followup to commit dd2261ed45aa ("hrtimer: Protect lockless access to timer->base") lock_hrtimer_base() fetches timer->base without lock exclusion. Compiler is allowed to read timer->base twice (even if considered dumb) and we could end up trying to lock migration_base and return _base. base