Re: [PATCH] hso: fix handling of modem port SERIAL_STATE notifications

2014-01-06 Thread David Miller
From: Dan Williams Date: Mon, 06 Jan 2014 15:39:40 -0600 > If the driver ever gets to that callback for any !Modem port, something > is horribly wrong, which the BUG_ON() was attempting to make explicit. > The driver only enables that callback for the Modem port, so yeah, it's > somewhat defensiv

Re: [PATCH] hso: fix handling of modem port SERIAL_STATE notifications

2014-01-06 Thread Dan Williams
On Mon, 2014-01-06 at 16:30 -0500, David Miller wrote: > From: Dan Williams > Date: Mon, 06 Jan 2014 10:07:29 -0600 > > > The existing serial state notification handling expected older Option > > devices, having a hardcoded assumption that the Modem port was always > > USB interface #2. That isn

Re: [PATCH] hso: fix handling of modem port SERIAL_STATE notifications

2014-01-06 Thread David Miller
From: Dan Williams Date: Mon, 06 Jan 2014 10:07:29 -0600 > The existing serial state notification handling expected older Option > devices, having a hardcoded assumption that the Modem port was always > USB interface #2. That isn't true for devices from the past few years. > > hso_serial_state_

[PATCH] hso: fix handling of modem port SERIAL_STATE notifications

2014-01-06 Thread Dan Williams
The existing serial state notification handling expected older Option devices, having a hardcoded assumption that the Modem port was always USB interface #2. That isn't true for devices from the past few years. hso_serial_state_notification is a local cache of a USB Communications Interface Class