Re: [PATCH] huegtlbfs: fix races and page leaks during migration

2019-02-26 Thread Mike Kravetz
On 2/25/19 11:44 PM, Naoya Horiguchi wrote: > Hi Mike, > > On Thu, Feb 21, 2019 at 11:11:06AM -0800, Mike Kravetz wrote: ... >> From: Mike Kravetz >> Date: Thu, 21 Feb 2019 11:01:04 -0800 >> Subject: [PATCH] huegtlbfs: fix races and page leaks during migration > &

Re: [PATCH] huegtlbfs: fix races and page leaks during migration

2019-02-25 Thread Naoya Horiguchi
orry for the churn. As I find and fix one issue I seem to discover another. > There is still at least one more issue with private pages when COW comes into > play. I continue to work that. I wanted to send this patch earlier as it > is pretty easy to hit the bugs if you try. If you

Re: [PATCH] huegtlbfs: fix races and page leaks during migration

2019-02-21 Thread Andrew Morton
On Thu, 21 Feb 2019 11:11:06 -0800 Mike Kravetz wrote: > > Sorry for the churn. As I find and fix one issue I seem to discover another. > There is still at least one more issue with private pages when COW comes into > play. I continue to work that. I wanted to send this patch earlier as it >

Re: [PATCH] huegtlbfs: fix races and page leaks during migration

2019-02-21 Thread Mike Kravetz
updated patch below. Sorry for the churn. As I find and fix one issue I seem to discover another. There is still at least one more issue with private pages when COW comes into play. I continue to work that. I wanted to send this patch earlier as it is pretty easy to hit the bugs if you try. If

Re: [PATCH] huegtlbfs: fix races and page leaks during migration

2019-02-20 Thread Andrew Morton
On Tue, 12 Feb 2019 14:14:00 -0800 Mike Kravetz wrote: > hugetlb pages should only be migrated if they are 'active'. The routines > set/clear_page_huge_active() modify the active state of hugetlb pages. > When a new hugetlb page is allocated at fault time, set_page_huge_active > is called before

Re: [PATCH] huegtlbfs: fix races and page leaks during migration

2019-02-13 Thread Mike Kravetz
s in explicitly mounted filesystem is still fixed by this patch. However, the commit message should be changed to more accurately reflect testing and observed outcomes. The patch with only commit message changes is below: From: Mike Kravetz Date: Tue, 12 Feb 2019 10:58:28 -0800 Subject: [PATCH] hueg

[PATCH] huegtlbfs: fix races and page leaks during migration

2019-02-12 Thread Mike Kravetz
hugetlb pages should only be migrated if they are 'active'. The routines set/clear_page_huge_active() modify the active state of hugetlb pages. When a new hugetlb page is allocated at fault time, set_page_huge_active is called before the page is locked. Therefore, another thread could race and mi