Re: [PATCH] hugetlb_cgroup: explicitly init the early_init field

On 2014/4/22 15:01, Jianyu Zhan wrote: > Hi, hillf, > > On Tue, Apr 22, 2014 at 2:47 PM, Hillf Danton wrote: >> But other fields still missed, if any. Fair? > > yep, it is not fair. > > Sure for this global variable struct, if not initailized, its all > fields will be initialized > to 0 or null

Re: [PATCH] hugetlb_cgroup: explicitly init the early_init field

Hi, hillf, On Tue, Apr 22, 2014 at 2:47 PM, Hillf Danton wrote: > But other fields still missed, if any. Fair? yep, it is not fair. Sure for this global variable struct, if not initailized, its all fields will be initialized to 0 or null(depending on its type). The point here is no to deprive

Re: [PATCH] hugetlb_cgroup: explicitly init the early_init field

On Tue, Apr 22, 2014 at 1:30 PM, Jianyu Zhan wrote: > For a cgroup subsystem who should init early, then it should carefully > take care of the implementation of css_alloc, because it will be called > before mm_init() setup the world. > > Luckily we don't, and we better explicitly assign the early

[PATCH] hugetlb_cgroup: explicitly init the early_init field

For a cgroup subsystem who should init early, then it should carefully take care of the implementation of css_alloc, because it will be called before mm_init() setup the world. Luckily we don't, and we better explicitly assign the early_init field to 0, for document reason. Signed-off-by: Jianyu