Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-02-02 Thread Guenter Roeck
On Mon, Feb 02, 2015 at 09:12:57AM +0100, Robert Rosengren wrote: > On 01/31/2015 09:11 PM, Guenter Roeck wrote: > >On 01/29/2015 11:30 AM, Guenter Roeck wrote: > >>On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: > Is your hardware big endian or little endian ? > >>>CONFIG_CPU

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-02-02 Thread Robert Rosengren
On 01/31/2015 09:11 PM, Guenter Roeck wrote: On 01/29/2015 11:30 AM, Guenter Roeck wrote: On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: Is your hardware big endian or little endian ? CONFIG_CPU_LITTLE_ENDIAN=y Hi Robert, I have another question: What is your i2c controll

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-31 Thread Guenter Roeck
On 01/29/2015 11:30 AM, Guenter Roeck wrote: On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: Is your hardware big endian or little endian ? CONFIG_CPU_LITTLE_ENDIAN=y Hi Robert, I have another question: What is your i2c controller type ? Robert, I now tried both 3.15

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-29 Thread Guenter Roeck
On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: > > > > >Is your hardware big endian or little endian ? > CONFIG_CPU_LITTLE_ENDIAN=y > Hi Robert, I have another question: What is your i2c controller type ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubs

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-29 Thread Guenter Roeck
On 01/29/2015 04:07 AM, Robert Rosengren wrote: On 01/29/2015 08:05 AM, Guenter Roeck wrote: Ah, don't bother then. I should hopefully get the samples in a couple of days. i2cdump was easily built, so here is the output: 0,8 1,9 2,a 3,b 4,c 5,d 6,e 7,f 00: 1301 1301 1301 1301 1301

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-29 Thread Robert Rosengren
On 01/29/2015 08:05 AM, Guenter Roeck wrote: Ah, don't bother then. I should hopefully get the samples in a couple of days. i2cdump was easily built, so here is the output: 0,8 1,9 2,a 3,b 4,c 5,d 6,e 7,f 00: 1301 1301 1301 1301 1301 1301 1301 1301 08: 4101 6901 6a01 6901 6901 6901

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-28 Thread Guenter Roeck
On 01/28/2015 11:00 PM, Robert Rosengren wrote: On 01/28/2015 03:50 PM, Guenter Roeck wrote: Can you possibly send me the output from i2cdump ? That might help figuring out what is going on. I don't have i2cdump (I suppose that you mean the lm-sensors tool) available for my hardware. I'll giv

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-28 Thread Robert Rosengren
On 01/28/2015 03:50 PM, Guenter Roeck wrote: Can you possibly send me the output from i2cdump ? That might help figuring out what is going on. I don't have i2cdump (I suppose that you mean the lm-sensors tool) available for my hardware. I'll give it a go to compile it... BR, Robert -- To unsu

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-28 Thread Guenter Roeck
On 01/27/2015 10:18 PM, Robert Rosengren wrote: I tested the driver on 3.15 version of the kernel. Having looked in the git log of regmap.c and regmap-i2c.c, there has been some endianess-related patches going into the kernel in newer versions. Maybe that is the reason for me seeing this pr

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Robert Rosengren
My previous mail got blocked by mailing lists for some reasons, so trying once more. I apologize if spamming. On 01/28/2015 07:18 AM, Robert Rosengren wrote: On 01/28/2015 05:06 AM, Guenter Roeck wrote: On 01/27/2015 02:34 PM, Jean Delvare wrote: >On Tue, 27 Jan 2015 12:05:53 -0800, Guenter R

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Guenter Roeck
On 01/27/2015 02:34 PM, Jean Delvare wrote: On Tue, 27 Jan 2015 12:05:53 -0800, Guenter Roeck wrote: On Tue, Jan 27, 2015 at 08:54:34PM +0100, Robert Rosengren wrote: Guenter and Jean, To sum up, my problems was related my kernel and hardware configuration, and it now works. Many thanks for y

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Jean Delvare
On Tue, 27 Jan 2015 12:05:53 -0800, Guenter Roeck wrote: > On Tue, Jan 27, 2015 at 08:54:34PM +0100, Robert Rosengren wrote: > > Guenter and Jean, > > > > To sum up, my problems was related my kernel and hardware configuration, > > and it now works. Many thanks for your input! > > > > However,

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Guenter Roeck
On Tue, Jan 27, 2015 at 08:54:34PM +0100, Robert Rosengren wrote: > Guenter and Jean, > > To sum up, my problems was related my kernel and hardware configuration, and > it now works. Many thanks for your input! > > However, the values retrieved from hwmon sysfs is not the same as before the >

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Robert Rosengren
Guenter and Jean, To sum up, my problems was related my kernel and hardware configuration, and it now works. Many thanks for your input! However, the values retrieved from hwmon sysfs is not the same as before the regmap patch. Guenter, the byte swap for the regval retrieved by regmap_read. I

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Guenter Roeck
On Tue, Jan 27, 2015 at 08:59:35AM +0100, Robert Rosengren wrote: > On 01/16/2015 07:30 PM, Guenter Roeck wrote: > >I sent a couple of patches a minute ago which should take care of the issue. > >Would be great if you can test it. > I applied the v2 versions of the patches for a quick test, but it

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Guenter Roeck
On 01/26/2015 11:59 PM, Robert Rosengren wrote: On 01/16/2015 07:30 PM, Guenter Roeck wrote: I sent a couple of patches a minute ago which should take care of the issue. Would be great if you can test it. I applied the v2 versions of the patches for a quick test, but it was not successful. Hav

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Guenter Roeck
On 01/27/2015 02:37 AM, Jean Delvare wrote: Hi Robert, Le Tuesday 27 January 2015 à 08:59 +0100, Robert Rosengren a écrit : On 01/16/2015 07:30 PM, Guenter Roeck wrote: I sent a couple of patches a minute ago which should take care of the issue. Would be great if you can test it. I applied th

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Guenter Roeck
On 01/26/2015 11:59 PM, Robert Rosengren wrote: On 01/16/2015 07:30 PM, Guenter Roeck wrote: I sent a couple of patches a minute ago which should take care of the issue. Would be great if you can test it. I applied the v2 versions of the patches for a quick test, but it was not successful. Hav

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Jean Delvare
Hi Robert, Le Tuesday 27 January 2015 à 08:59 +0100, Robert Rosengren a écrit : > On 01/16/2015 07:30 PM, Guenter Roeck wrote: > > I sent a couple of patches a minute ago which should take care of the issue. > > Would be great if you can test it. > I applied the v2 versions of the patches for a qu

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-27 Thread Robert Rosengren
On 01/16/2015 07:30 PM, Guenter Roeck wrote: I sent a couple of patches a minute ago which should take care of the issue. Would be great if you can test it. I applied the v2 versions of the patches for a quick test, but it was not successful. Haven't done any further investigation on what the p

SV: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-19 Thread Robert Rosengren
> On Fri, Jan 16, 2015 at 06:52:06AM -0800, Guenter Roeck wrote: > > I am basically fine with the patch, though I would prefer replacing > > the entire update handling and chip access with regmap. Would you be > > interested in doing that ? > > > I sent a couple of patches a minute ago which shoul

Re: [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-16 Thread Guenter Roeck
On Fri, Jan 16, 2015 at 01:05:22PM +0100, Robert Rosengren wrote: > The default sample interval may be too slow for certain clients. This > patch makes it configurable via the platform_data. > > Signed-off-by: Robert Rosengren > Signed-off-by: Johan Adolfsson Robert, can you send me the output

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-16 Thread Guenter Roeck
On Fri, Jan 16, 2015 at 06:52:06AM -0800, Guenter Roeck wrote: > On 01/16/2015 04:05 AM, Robert Rosengren wrote: > >The default sample interval may be too slow for certain clients. This > >patch makes it configurable via the platform_data. > > > >Signed-off-by: Robert Rosengren > >Signed-off-by: J

Re: [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-16 Thread Guenter Roeck
On 01/16/2015 04:05 AM, Robert Rosengren wrote: The default sample interval may be too slow for certain clients. This patch makes it configurable via the platform_data. Signed-off-by: Robert Rosengren Signed-off-by: Johan Adolfsson I am basically fine with the patch, though I would prefer re

[PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-16 Thread Robert Rosengren
The default sample interval may be too slow for certain clients. This patch makes it configurable via the platform_data. Signed-off-by: Robert Rosengren Signed-off-by: Johan Adolfsson --- drivers/hwmon/ads7828.c | 11 ++- include/linux/platform_data/ads7828.h | 2 ++ 2 fi