Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

2021-03-29 Thread Guenter Roeck
On 3/29/21 8:31 PM, Václav Kubernát wrote: > Hi Guenter, > > Thank you for the review. > > po 29. 3. 2021 v 19:47 odesílatel Guenter Roeck napsal: >> >> On 3/29/21 7:38 AM, Václav Kubernát wrote: >>> After some testing, I have found out there is a timing issue with this >>> device. After setting

Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

2021-03-29 Thread Václav Kubernát
Hi Guenter, Thank you for the review. po 29. 3. 2021 v 19:47 odesílatel Guenter Roeck napsal: > > On 3/29/21 7:38 AM, Václav Kubernát wrote: > > After some testing, I have found out there is a timing issue with this > > device. After setting page, the device doesn't immediately react and > > giv

Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

2021-03-29 Thread kernel test robot
Hi "Václav, Thank you for the patch! Yet something to improve: [auto build test ERROR on hwmon/hwmon-next] [also build test ERROR on v5.12-rc5 next-20210329] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

2021-03-29 Thread kernel test robot
Hi "Václav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on v5.12-rc5 next-20210329] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as do

Re: [PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

2021-03-29 Thread Guenter Roeck
On 3/29/21 7:38 AM, Václav Kubernát wrote: > After some testing, I have found out there is a timing issue with this > device. After setting page, the device doesn't immediately react and > gives values from the previous page for some time. This is why there > needs to be a delay between pmbus_set_p

[PATCH] hwmon: Add driver for fsp-3y PSUs and PDUs

2021-03-29 Thread Václav Kubernát
After some testing, I have found out there is a timing issue with this device. After setting page, the device doesn't immediately react and gives values from the previous page for some time. This is why there needs to be a delay between pmbus_set_page and the actual read. Also, a lot of the standa