Re: [PATCH] hwmon: adm1275: Make sure we are reading enough data for different chips

2020-07-08 Thread Guenter Roeck
On 7/8/20 8:30 PM, Chu Lin wrote: > On Wed, Jul 8, 2020 at 5:33 PM Guenter Roeck wrote: >> >> On 7/8/20 4:53 PM, Chu Lin wrote: >>> Issue: >>> When binding adm1272 to the adm1275 driver, PEC error is reported. >>> See blow: >> >> s/blow/below/ >> >> Also, unless I am missing something, the error i

Re: [PATCH] hwmon: adm1275: Make sure we are reading enough data for different chips

2020-07-08 Thread Chu Lin
On Wed, Jul 8, 2020 at 5:33 PM Guenter Roeck wrote: > > On 7/8/20 4:53 PM, Chu Lin wrote: > > Issue: > > When binding adm1272 to the adm1275 driver, PEC error is reported. > > See blow: > > s/blow/below/ > > Also, unless I am missing something, the error is only seen if PEC is > enabled. This is

Re: [PATCH] hwmon: adm1275: Make sure we are reading enough data for different chips

2020-07-08 Thread Guenter Roeck
On 7/8/20 4:53 PM, Chu Lin wrote: > Issue: > When binding adm1272 to the adm1275 driver, PEC error is reported. > See blow: s/blow/below/ Also, unless I am missing something, the error is only seen if PEC is enabled. > adm1275: probe of failed with error -74 > > Diagnosis: > Per the datash

[PATCH] hwmon: adm1275: Make sure we are reading enough data for different chips

2020-07-08 Thread Chu Lin
Issue: When binding adm1272 to the adm1275 driver, PEC error is reported. See blow: adm1275: probe of failed with error -74 Diagnosis: Per the datasheet of adm1272 and adm1278 (www.analog.com), PMON_CONFIG (0xd4) is 16bits wide. On the other hand, PMON_CONFIG (0xd4) for adm1275 is 8bits wide.