Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-07 Thread Hoan Tran
Hi Guenter, On Wed, Sep 7, 2016 at 12:24 PM, Guenter Roeck wrote: > On Wed, Sep 07, 2016 at 11:55:06AM -0700, Hoan Tran wrote: >> Hi Guenter, >> >> On Tue, Sep 6, 2016 at 11:39 PM, Guenter Roeck wrote: >> > On 09/06/2016 11:07 PM, Hoan Tran wrote: >> >> >> >> Hi Guenter, >> >> >> >> On Tue, Sep

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-07 Thread Guenter Roeck
On Wed, Sep 07, 2016 at 11:55:06AM -0700, Hoan Tran wrote: > Hi Guenter, > > On Tue, Sep 6, 2016 at 11:39 PM, Guenter Roeck wrote: > > On 09/06/2016 11:07 PM, Hoan Tran wrote: > >> > >> Hi Guenter, > >> > >> On Tue, Sep 6, 2016 at 10:50 PM, Guenter Roeck wrote: > >>> > >>> On 09/06/2016 10:21 PM

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-07 Thread Hoan Tran
Hi Guenter, On Tue, Sep 6, 2016 at 11:39 PM, Guenter Roeck wrote: > On 09/06/2016 11:07 PM, Hoan Tran wrote: >> >> Hi Guenter, >> >> On Tue, Sep 6, 2016 at 10:50 PM, Guenter Roeck wrote: >>> >>> On 09/06/2016 10:21 PM, Hoan Tran wrote: Hi Guenter, Thank for your quick re

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Guenter Roeck
On 09/06/2016 11:07 PM, Hoan Tran wrote: Hi Guenter, On Tue, Sep 6, 2016 at 10:50 PM, Guenter Roeck wrote: On 09/06/2016 10:21 PM, Hoan Tran wrote: Hi Guenter, Thank for your quick review ! On Tue, Sep 6, 2016 at 9:35 PM, Guenter Roeck wrote: On 09/06/2016 08:46 PM, Hoan Tran wrote:

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Hoan Tran
Hi Guenter, On Tue, Sep 6, 2016 at 10:50 PM, Guenter Roeck wrote: > On 09/06/2016 10:21 PM, Hoan Tran wrote: >> >> Hi Guenter, >> >> Thank for your quick review ! >> >> On Tue, Sep 6, 2016 at 9:35 PM, Guenter Roeck wrote: >>> >>> On 09/06/2016 08:46 PM, Hoan Tran wrote: The system

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Guenter Roeck
On 09/06/2016 10:21 PM, Hoan Tran wrote: Hi Guenter, Thank for your quick review ! On Tue, Sep 6, 2016 at 9:35 PM, Guenter Roeck wrote: On 09/06/2016 08:46 PM, Hoan Tran wrote: The system crashes during probing xgene-hwmon driver when temperature alarm interrupt occurs before. It's because

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Hoan Tran
Hi Guenter, Thank for your quick review ! On Tue, Sep 6, 2016 at 9:35 PM, Guenter Roeck wrote: > On 09/06/2016 08:46 PM, Hoan Tran wrote: >> >> The system crashes during probing xgene-hwmon driver when temperature >> alarm interrupt occurs before. >> It's because >> - xgene_hwmon_probe() reques

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Guenter Roeck
On 09/06/2016 08:46 PM, Hoan Tran wrote: The system crashes during probing xgene-hwmon driver when temperature alarm interrupt occurs before. It's because - xgene_hwmon_probe() requests PCC mailbox channel which also enables the mailbox interrupt. - As temperature alarm interrupt is pending, IS

[PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Hoan Tran
The system crashes during probing xgene-hwmon driver when temperature alarm interrupt occurs before. It's because - xgene_hwmon_probe() requests PCC mailbox channel which also enables the mailbox interrupt. - As temperature alarm interrupt is pending, ISR runs and crashes when accesses into inval