Re: [PATCH] hwmon coretemp: Remove bogus __cpuinitdata etc cleanup

2007-09-02 Thread Rudolf Marek
>> [ Rudolf, Mark, would it be acceptable to you to remove all the open >> #ifdef HOTPLUG_CPU from this file and replace them with __cpuinit{data} >> instead? That could increase size of modular builds, but would remain >> consistent with rest of kernel, and make the file #ifdef-clean ... ]

Re: [PATCH] hwmon coretemp: Remove bogus __cpuinitdata etc cleanup

2007-09-02 Thread Mark M. Hoffman
Hi Satyam: * Satyam Sharma <[EMAIL PROTECTED]> [2007-08-23 09:14:25 +0530]: > > The CPU hotplug notifier_block coretemp_cpu_notifier is already defined > inside an #ifdef HOTPLUG_CPU, therefore marking it as __cpuinitdata is > quite a pointless thing to do. > > Also, remove duplicate prototype o

Re: [PATCH] hwmon coretemp: Remove bogus __cpuinitdata etc cleanup

2007-08-24 Thread Rudolf Marek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, > The CPU hotplug notifier_block coretemp_cpu_notifier is already defined > inside an #ifdef HOTPLUG_CPU, therefore marking it as __cpuinitdata is > quite a pointless thing to do. Yep true. > Also, remove duplicate prototype of function coretemp

[PATCH] hwmon coretemp: Remove bogus __cpuinitdata etc cleanup

2007-08-22 Thread Satyam Sharma
The CPU hotplug notifier_block coretemp_cpu_notifier is already defined inside an #ifdef HOTPLUG_CPU, therefore marking it as __cpuinitdata is quite a pointless thing to do. Also, remove duplicate prototype of function coretemp_update_device() at the top of this file (another one already exists b