Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-27 Thread Sudip Mukherjee
On Wednesday 25 May 2016 03:36 PM, Arnd Bergmann wrote: On Wednesday, May 25, 2016 7:35:17 AM CEST Sudip Mukherjee wrote: On Tuesday 24 May 2016 02:05 AM, Arnd Bergmann wrote: On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: We have been getting build warning about:

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-27 Thread Sudip Mukherjee
On Wednesday 25 May 2016 03:36 PM, Arnd Bergmann wrote: On Wednesday, May 25, 2016 7:35:17 AM CEST Sudip Mukherjee wrote: On Tuesday 24 May 2016 02:05 AM, Arnd Bergmann wrote: On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: We have been getting build warning about:

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-25 Thread Arnd Bergmann
On Wednesday, May 25, 2016 7:35:17 AM CEST Sudip Mukherjee wrote: > On Tuesday 24 May 2016 02:05 AM, Arnd Bergmann wrote: > > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: > >> We have been getting build warning about: > >> drivers/char/hw_random/stm32-rng.c: In function

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-25 Thread Arnd Bergmann
On Wednesday, May 25, 2016 7:35:17 AM CEST Sudip Mukherjee wrote: > On Tuesday 24 May 2016 02:05 AM, Arnd Bergmann wrote: > > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: > >> We have been getting build warning about: > >> drivers/char/hw_random/stm32-rng.c: In function

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-25 Thread Sudip Mukherjee
On Tuesday 24 May 2016 02:05 AM, Arnd Bergmann wrote: On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: We have been getting build warning about: drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-25 Thread Sudip Mukherjee
On Tuesday 24 May 2016 02:05 AM, Arnd Bergmann wrote: On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: We have been getting build warning about: drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-25 Thread Sudip Mukherjee
On Tuesday 24 May 2016 02:50 PM, Maxime Coquelin wrote: 2016-05-24 10:58 GMT+02:00 Arnd Bergmann : On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-25 Thread Sudip Mukherjee
On Tuesday 24 May 2016 02:50 PM, Maxime Coquelin wrote: 2016-05-24 10:58 GMT+02:00 Arnd Bergmann : On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 92a810648bd0..2a0fc90e4dc3 100644 ---

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 12:09 GMT+02:00 Daniel Thompson : > On 24/05/16 09:50, Maxime Coquelin wrote: >> >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> --- a/drivers/char/hw_random/stm32-rng.c

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 12:09 GMT+02:00 Daniel Thompson : > On 24/05/16 09:50, Maxime Coquelin wrote: >> >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> --- a/drivers/char/hw_random/stm32-rng.c >> +++

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Daniel Thompson
On 24/05/16 09:50, Maxime Coquelin wrote: diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 92a810648bd0..2a0fc90e4dc3 100644 --- a/drivers/char/hw_random/stm32-rng.c +++ b/drivers/char/hw_random/stm32-rng.c @@ -68,6 +68,10 @@ static int

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Daniel Thompson
On 24/05/16 09:50, Maxime Coquelin wrote: diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 92a810648bd0..2a0fc90e4dc3 100644 --- a/drivers/char/hw_random/stm32-rng.c +++ b/drivers/char/hw_random/stm32-rng.c @@ -68,6 +68,10 @@ static int

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 10:58 GMT+02:00 Arnd Bergmann : > On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> ---

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 10:58 GMT+02:00 Arnd Bergmann : > On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> --- a/drivers/char/hw_random/stm32-rng.c >> +++

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Arnd Bergmann
On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: > diff --git a/drivers/char/hw_random/stm32-rng.c > b/drivers/char/hw_random/stm32-rng.c > index 92a810648bd0..2a0fc90e4dc3 100644 > --- a/drivers/char/hw_random/stm32-rng.c > +++ b/drivers/char/hw_random/stm32-rng.c > @@ -68,6

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Arnd Bergmann
On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: > diff --git a/drivers/char/hw_random/stm32-rng.c > b/drivers/char/hw_random/stm32-rng.c > index 92a810648bd0..2a0fc90e4dc3 100644 > --- a/drivers/char/hw_random/stm32-rng.c > +++ b/drivers/char/hw_random/stm32-rng.c > @@ -68,6

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 10:32 GMT+02:00 Arnd Bergmann : > On Tuesday, May 24, 2016 9:59:41 AM CEST Maxime Coquelin wrote: >> 2016-05-23 22:35 GMT+02:00 Arnd Bergmann : >> > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> >> diff --git

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 10:32 GMT+02:00 Arnd Bergmann : > On Tuesday, May 24, 2016 9:59:41 AM CEST Maxime Coquelin wrote: >> 2016-05-23 22:35 GMT+02:00 Arnd Bergmann : >> > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> >> diff --git a/drivers/char/hw_random/stm32-rng.c >> >>

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Arnd Bergmann
On Tuesday, May 24, 2016 9:59:41 AM CEST Maxime Coquelin wrote: > 2016-05-23 22:35 GMT+02:00 Arnd Bergmann : > > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: > >> diff --git a/drivers/char/hw_random/stm32-rng.c > >> b/drivers/char/hw_random/stm32-rng.c > >> index

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Arnd Bergmann
On Tuesday, May 24, 2016 9:59:41 AM CEST Maxime Coquelin wrote: > 2016-05-23 22:35 GMT+02:00 Arnd Bergmann : > > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: > >> diff --git a/drivers/char/hw_random/stm32-rng.c > >> b/drivers/char/hw_random/stm32-rng.c > >> index

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-23 22:35 GMT+02:00 Arnd Bergmann : > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> We have been getting build warning about: >> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': >> drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr'

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-23 22:35 GMT+02:00 Arnd Bergmann : > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> We have been getting build warning about: >> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': >> drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used >>

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-23 Thread Arnd Bergmann
On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: > We have been getting build warning about: > drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': > drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used > uninitialized

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-23 Thread Arnd Bergmann
On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: > We have been getting build warning about: > drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': > drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used > uninitialized

[PATCH] hwrng: stm32 - fix build warning

2016-05-23 Thread Sudip Mukherjee
We have been getting build warning about: drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used uninitialized in this function On checking the code it turns out that sr can

[PATCH] hwrng: stm32 - fix build warning

2016-05-23 Thread Sudip Mukherjee
We have been getting build warning about: drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used uninitialized in this function On checking the code it turns out that sr can