Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

2019-08-12 Thread Geert Uytterhoeven
Hi Max, On Tue, Aug 13, 2019 at 12:21 AM Max Staudt wrote: > On 08/12/2019 11:37 AM, Geert Uytterhoeven wrote: > >> + iowrite8(val, address); > > > > As this is on a Zorro bus, z_writeb()? > > I forgot to ask about this. > > What is the reasoning behind having a separate z_writeb() for Zorr

Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

2019-08-12 Thread Max Staudt
On 08/12/2019 11:37 AM, Geert Uytterhoeven wrote: >> + iowrite8(val, address); > > As this is on a Zorro bus, z_writeb()? I forgot to ask about this. What is the reasoning behind having a separate z_writeb() for Zorro? As far as I can see in arch/m68k/include/asm this maps 1:1 to a direct

Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

2019-08-12 Thread Max Staudt
On 08/12/2019 01:07 PM, Geert Uytterhoeven wrote: >> It sets the sensor modes in the LTC2990 and enables the three sensors listed >> below. I should have clarified this. >> >> I tried to integrate this in the driver, but ltc2990 only allows reading >> this configuration out of a device tree. Is t

Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

2019-08-12 Thread Geert Uytterhoeven
Hi Max, On Mon, Aug 12, 2019 at 12:43 PM Max Staudt wrote: > On 08/12/2019 11:37 AM, Geert Uytterhoeven wrote: > >> + /* > >> +* The 2019 a1k.org PCBs have an LTC2990 at 0x4c, so start > >> +* it automatically once ltc2990 is modprobed. > >> +* > >> +* in0 is

Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

2019-08-12 Thread Max Staudt
Hi Geert, Thanks for your feedback! Replies below. On 08/12/2019 11:37 AM, Geert Uytterhoeven wrote: > What about the RTC? The schematics show both a ds1620 and pcf8583. Oh no! I missed those in the original project, in my mind it didn't have any extra hardware at all. I only own the new board

Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

2019-08-12 Thread Geert Uytterhoeven
Hi Max, Thanks for your patch! On Sun, Aug 11, 2019 at 6:33 AM Max Staudt wrote: > This is the i2c-icy driver for the ICY board for Amiga computers. > It connects a PCF8584 I2C controller to the Zorro bus, providing I2C > connectivity. The original documentation can be found on Aminet: > > https

Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

2019-08-10 Thread Max Staudt
On 08/11/2019 06:32 AM, Max Staudt wrote: > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -1300,6 +1300,17 @@ config I2C_ELEKTOR > This support is also available as a module. If so, the module > will be called i2c-elektor. > > +config I2C_ICY > + tr

[PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

2019-08-10 Thread Max Staudt
This is the i2c-icy driver for the ICY board for Amiga computers. It connects a PCF8584 I2C controller to the Zorro bus, providing I2C connectivity. The original documentation can be found on Aminet: https://aminet.net/package/docs/hard/icy Since the 2019 a1k.org community re-print of these PCBs