Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-10-15 Thread Srinivas Pandruvada
Hi Lars and Jean, Are you taking this patch further to take care about ACPI related stuff submitted by Mika? Thanks, Srinivas On Fri, 2014-10-03 at 12:46 +0200, Wolfram Sang wrote: > > > Ok, looks like there are two main differences in the two implementations. > > > > > > 1) The ACPI one uses a

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-10-03 Thread Wolfram Sang
> > Ok, looks like there are two main differences in the two implementations. > > > > 1) The ACPI one uses a integer index and the DT one uses a string index to > > lookup the device. > > > > The problem with the index lookup is that the order is binding specific. So > > it might be different bet

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-22 Thread Mika Westerberg
On Mon, Sep 22, 2014 at 04:11:52PM +0200, Lars-Peter Clausen wrote: > On 09/22/2014 03:45 PM, Mika Westerberg wrote: > >On Mon, Sep 22, 2014 at 03:27:36PM +0200, Lars-Peter Clausen wrote: > >>On 09/22/2014 12:45 PM, Mika Westerberg wrote: > >>>On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel H

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-22 Thread Lars-Peter Clausen
On 09/22/2014 03:45 PM, Mika Westerberg wrote: On Mon, Sep 22, 2014 at 03:27:36PM +0200, Lars-Peter Clausen wrote: On 09/22/2014 12:45 PM, Mika Westerberg wrote: On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: Some I2C devices have multiple addresses assigned, for example

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-22 Thread Mika Westerberg
On Mon, Sep 22, 2014 at 03:27:36PM +0200, Lars-Peter Clausen wrote: > On 09/22/2014 12:45 PM, Mika Westerberg wrote: > >On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: > >>Some I2C devices have multiple addresses assigned, for example each address > >>corresponding to a differ

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-22 Thread Lars-Peter Clausen
On 09/22/2014 12:45 PM, Mika Westerberg wrote: On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: Some I2C devices have multiple addresses assigned, for example each address corresponding to a different internal register map page of the device. So far drivers which need suppor

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-22 Thread Mika Westerberg
On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: > Some I2C devices have multiple addresses assigned, for example each address > corresponding to a different internal register map page of the device. > So far drivers which need support for this have handled this with a driver >

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-21 Thread Lars-Peter Clausen
On 09/21/2014 07:49 PM, Wolfram Sang wrote: This raises the first question for me: Are the additional addresses configurable? Sadly, I can't find good documentation for the adv7604. Otherwise, if I know I have a adv7604 and know its addresses, this information should go into the driver and not

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-21 Thread Wolfram Sang
> >This raises the first question for me: Are the additional addresses > >configurable? Sadly, I can't find good documentation for the adv7604. > >Otherwise, if I know I have a adv7604 and know its addresses, this > >information should go into the driver and not the DT. > > > > They are. The curr

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-20 Thread Lars-Peter Clausen
On 09/20/2014 06:49 PM, Wolfram Sang wrote: On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: Some I2C devices have multiple addresses assigned, for example each address corresponding to a different internal register map page of the device. So far drivers which need support f

Re: [PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-20 Thread Wolfram Sang
On Fri, Sep 05, 2014 at 04:02:19PM +0200, Jean-Michel Hautbois wrote: > Some I2C devices have multiple addresses assigned, for example each address > corresponding to a different internal register map page of the device. > So far drivers which need support for this have handled this with a driver >

[PATCH] i2c: Add generic support passing secondary devices addresses

2014-09-05 Thread Jean-Michel Hautbois
Some I2C devices have multiple addresses assigned, for example each address corresponding to a different internal register map page of the device. So far drivers which need support for this have handled this with a driver specific and non-generic implementation, e.g. passing the additional address