Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-24 Thread Wolfram Sang
On Tue, Feb 19, 2019 at 11:30:27AM -0800, Jim Broadus wrote: > A previous change allowed I2C client devices to discover new IRQs upon > reprobe by clearing the IRQ in i2c_device_remove. However, if an IRQ was > assigned in i2c_new_device, that information is lost. > > For example, the touchscreen

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-22 Thread Wolfram Sang
> I'm also more familiar with device-tree (just came across this on my personal > laptop) but happy to review and test at the risk of learning something. :) Thanks! signature.asc Description: PGP signature

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-22 Thread Jim Broadus
On Fri, Feb 22, 2019 at 3:32 AM Wolfram Sang wrote: > > > > > > But I still have the feeling that the problem is not solved at the > > > > right place. In i2c_new_device() we are storing parts of the fields of > > > > struct i2c_board_info, and when resetting the irq we are losing > > > > informat

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-22 Thread Wolfram Sang
> > > But I still have the feeling that the problem is not solved at the > > > right place. In i2c_new_device() we are storing parts of the fields of > > > struct i2c_board_info, and when resetting the irq we are losing > > > information. This patch solves that, but I wonder if the IRQ should > >

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-22 Thread Charles Keepax
On Fri, Feb 22, 2019 at 11:23:35AM +0100, Wolfram Sang wrote: > On Fri, Feb 22, 2019 at 11:15:59AM +0100, Benjamin Tissoires wrote: > > On Fri, Feb 22, 2019 at 12:26 AM Wolfram Sang wrote: > > > On Tue, Feb 19, 2019 at 11:30:27AM -0800, Jim Broadus wrote: > > > > A previous change allowed I2C clie

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-22 Thread Charles Keepax
On Fri, Feb 22, 2019 at 11:15:59AM +0100, Benjamin Tissoires wrote: > On Fri, Feb 22, 2019 at 12:26 AM Wolfram Sang wrote: > > On Tue, Feb 19, 2019 at 11:30:27AM -0800, Jim Broadus wrote: > > > A previous change allowed I2C client devices to discover new IRQs upon > > > reprobe by clearing the IRQ

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-22 Thread Wolfram Sang
On Fri, Feb 22, 2019 at 11:15:59AM +0100, Benjamin Tissoires wrote: > On Fri, Feb 22, 2019 at 12:26 AM Wolfram Sang wrote: > > > > On Tue, Feb 19, 2019 at 11:30:27AM -0800, Jim Broadus wrote: > > > A previous change allowed I2C client devices to discover new IRQs upon > > > reprobe by clearing the

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-22 Thread Benjamin Tissoires
On Fri, Feb 22, 2019 at 12:26 AM Wolfram Sang wrote: > > On Tue, Feb 19, 2019 at 11:30:27AM -0800, Jim Broadus wrote: > > A previous change allowed I2C client devices to discover new IRQs upon > > reprobe by clearing the IRQ in i2c_device_remove. However, if an IRQ was > > assigned in i2c_new_devi

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-21 Thread Wolfram Sang
On Tue, Feb 19, 2019 at 11:30:27AM -0800, Jim Broadus wrote: > A previous change allowed I2C client devices to discover new IRQs upon > reprobe by clearing the IRQ in i2c_device_remove. However, if an IRQ was > assigned in i2c_new_device, that information is lost. > > For example, the touchscreen

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-19 Thread Jim Broadus
Apologies.. This should have been marked v2. On Tue, Feb 19, 2019 at 11:30 AM Jim Broadus wrote: > > A previous change allowed I2C client devices to discover new IRQs upon > reprobe by clearing the IRQ in i2c_device_remove. However, if an IRQ was > assigned in i2c_new_device, that information is

[PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-19 Thread Jim Broadus
A previous change allowed I2C client devices to discover new IRQs upon reprobe by clearing the IRQ in i2c_device_remove. However, if an IRQ was assigned in i2c_new_device, that information is lost. For example, the touchscreen and trackpad devices on a Dell Inspiron laptop are I2C devices whose IR