Re: [PATCH] i2c: Fallback to of_node of parent

2013-11-25 Thread Wolfram Sang
On Sat, Nov 16, 2013 at 05:59:15PM +0100, Florian Meier wrote: > I have looked through all bus drivers and in most > cases they have a corresponding line that could be removed. > > Although, this patch would break i2c-powermac, because it > relies on the fact that of_node stays NULL. > > Any idea

Re: [PATCH] i2c: Fallback to of_node of parent

2013-11-16 Thread Florian Meier
I have looked through all bus drivers and in most cases they have a corresponding line that could be removed. Although, this patch would break i2c-powermac, because it relies on the fact that of_node stays NULL. Any idea how to handle that? Greetings, Florian On 16.11.2013 17:11, Florian Meier

Re: [PATCH] i2c: Fallback to of_node of parent

2013-11-16 Thread Florian Meier
Ok, I will try to find all relevant lines. Where is the best place to document this? Greetings, Florian 2013/11/16 Wolfram Sang : > >> + if (!dev->of_node && dev->parent) >> + dev->of_node = dev->parent->of_node; >> + > > That is not enough. Current drivers could then have the ass

Re: [PATCH] i2c: Fallback to of_node of parent

2013-11-16 Thread Wolfram Sang
> + if (!dev->of_node && dev->parent) > + dev->of_node = dev->parent->of_node; > + That is not enough. Current drivers could then have the assignment removed and even more important, this behaviour should be documented. Regards, Wolfram signature.asc Description: Digital s

[PATCH] i2c: Fallback to of_node of parent

2013-11-16 Thread Florian Meier
Many busses (e.g. tegra, omap, bcm2835) need to set the of_node of the adapter device to the one of the parent device, i.e. adap->dev.of_node = pdev->dev.of_node; As suggested by Stephen Warren, this could also be done in the i2c core and it is a common mistake to forget this line: I2C: BCM2835: