Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-09 Thread Christian Ruppert
Dear Lucas, On 04.05.2016 16:38, Lucas De Marchi wrote: > Hi Christian, > > On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert > wrote: >> Dear Lucas, >> >> On 22.04.2016 17:19, Lucas De Marchi wrote: >>> CC'ing Christian. >>> >>> On Fri, Apr 22, 2016 at 12:08 PM,

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-09 Thread Christian Ruppert
Dear Lucas, On 04.05.2016 16:38, Lucas De Marchi wrote: > Hi Christian, > > On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert > wrote: >> Dear Lucas, >> >> On 22.04.2016 17:19, Lucas De Marchi wrote: >>> CC'ing Christian. >>> >>> On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi >>> wrote: >

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-04 Thread Lucas De Marchi
Hi Christian, On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert wrote: > Dear Lucas, > > On 22.04.2016 17:19, Lucas De Marchi wrote: >> CC'ing Christian. >> >> On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi >> wrote: >>> Disabling the

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-04 Thread Lucas De Marchi
Hi Christian, On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert wrote: > Dear Lucas, > > On 22.04.2016 17:19, Lucas De Marchi wrote: >> CC'ing Christian. >> >> On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi >> wrote: >>> Disabling the adapter after each transfer is pretty bad for sensors and

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-02 Thread Christian Ruppert
Dear Lucas, On 22.04.2016 17:19, Lucas De Marchi wrote: > CC'ing Christian. > > On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi > wrote: >> Disabling the adapter after each transfer is pretty bad for sensors and >> other devices doing small transfers at a high rate.

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-02 Thread Christian Ruppert
Dear Lucas, On 22.04.2016 17:19, Lucas De Marchi wrote: > CC'ing Christian. > > On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi > wrote: >> Disabling the adapter after each transfer is pretty bad for sensors and >> other devices doing small transfers at a high rate. It slows down the >>

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-27 Thread Jarkko Nikula
On 04/25/2016 06:04 PM, Lucas De Marchi wrote: On 04/25/2016 08:51 AM, Jarkko Nikula wrote: [ ... ] @@ -413,8 +416,16 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev) struct i2c_msg *msgs = dev->msgs; u32 ic_con, ic_tar = 0; -/* Disable the adapter */ -

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-27 Thread Jarkko Nikula
On 04/25/2016 06:04 PM, Lucas De Marchi wrote: On 04/25/2016 08:51 AM, Jarkko Nikula wrote: [ ... ] @@ -413,8 +416,16 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev) struct i2c_msg *msgs = dev->msgs; u32 ic_con, ic_tar = 0; -/* Disable the adapter */ -

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-25 Thread Lucas De Marchi
On 04/25/2016 08:51 AM, Jarkko Nikula wrote: [ ... ] @@ -413,8 +416,16 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev) struct i2c_msg *msgs = dev->msgs; u32 ic_con, ic_tar = 0; -/* Disable the adapter */ -__i2c_dw_enable(dev, false); +if (dev->enabled) { +

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-25 Thread Lucas De Marchi
On 04/25/2016 08:51 AM, Jarkko Nikula wrote: [ ... ] @@ -413,8 +416,16 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev) struct i2c_msg *msgs = dev->msgs; u32 ic_con, ic_tar = 0; -/* Disable the adapter */ -__i2c_dw_enable(dev, false); +if (dev->enabled) { +

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-25 Thread Jarkko Nikula
On 04/22/2016 06:08 PM, Lucas De Marchi wrote: Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. During the transfer

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-25 Thread Jarkko Nikula
On 04/22/2016 06:08 PM, Lucas De Marchi wrote: Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. During the transfer

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
CC'ing Christian. On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi wrote: > Disabling the adapter after each transfer is pretty bad for sensors and > other devices doing small transfers at a high rate. It slows down the > transfer rate a lot since each of them have to

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
CC'ing Christian. On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi wrote: > Disabling the adapter after each transfer is pretty bad for sensors and > other devices doing small transfers at a high rate. It slows down the > transfer rate a lot since each of them have to wait the adapter to be >

[PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. During the transfer init we check the status register for no activity

[PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. During the transfer init we check the status register for no activity

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-08 Thread Christian Ruppert
On 2016-04-07 19:28, De Marchi, Lucas wrote: > Hi Christian, > > On Thu, 2016-04-07 at 15:37 +0200, Christian Ruppert wrote: >> Dear Lucas, >> >> Sorry for the late reply but I had to put our test environment back >> together to check this patch. I'll keep it around for a while in case >> you

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-08 Thread Christian Ruppert
On 2016-04-07 19:28, De Marchi, Lucas wrote: > Hi Christian, > > On Thu, 2016-04-07 at 15:37 +0200, Christian Ruppert wrote: >> Dear Lucas, >> >> Sorry for the late reply but I had to put our test environment back >> together to check this patch. I'll keep it around for a while in case >> you

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-08 Thread Jarkko Nikula
Hi On 04/01/2016 05:47 AM, Lucas De Marchi wrote: From: Lucas De Marchi Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-08 Thread Jarkko Nikula
Hi On 04/01/2016 05:47 AM, Lucas De Marchi wrote: From: Lucas De Marchi Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-07 Thread De Marchi, Lucas
Hi Christian, On Thu, 2016-04-07 at 15:37 +0200, Christian Ruppert wrote: > Dear Lucas, > > Sorry for the late reply but I had to put our test environment back > together to check this patch. I'll keep it around for a while in case > you have further iterations to test. np, I'll try to iterate

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-07 Thread De Marchi, Lucas
Hi Christian, On Thu, 2016-04-07 at 15:37 +0200, Christian Ruppert wrote: > Dear Lucas, > > Sorry for the late reply but I had to put our test environment back > together to check this patch. I'll keep it around for a while in case > you have further iterations to test. np, I'll try to iterate

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-07 Thread Christian Ruppert
Dear Lucas, Sorry for the late reply but I had to put our test environment back together to check this patch. I'll keep it around for a while in case you have further iterations to test. On 2016-04-01 04:47, Lucas De Marchi wrote: > From: Lucas De Marchi > > Disabling

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-07 Thread Christian Ruppert
Dear Lucas, Sorry for the late reply but I had to put our test environment back together to check this patch. I'll keep it around for a while in case you have further iterations to test. On 2016-04-01 04:47, Lucas De Marchi wrote: > From: Lucas De Marchi > > Disabling the adapter after each

[PATCH] i2c: designware: do not disable adapter after transfer

2016-03-31 Thread Lucas De Marchi
From: Lucas De Marchi Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. It was done in order

[PATCH] i2c: designware: do not disable adapter after transfer

2016-03-31 Thread Lucas De Marchi
From: Lucas De Marchi Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. It was done in order to avoid the adapter to