Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT

2016-04-24 Thread Wolfram Sang
On Wed, Apr 13, 2016 at 08:11:47PM +0800, Jisheng Zhang wrote: > Dear Rob, > > On Thu, 7 Apr 2016 12:57:59 -0500 Rob Herring wrote: > > > On Wed, Apr 06, 2016 at 03:28:00PM +0800, Jisheng Zhang wrote: > > > Sometimes, it's convenient to define the scl's high/low count directly, > > > e.g HW peopl

Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT

2016-04-13 Thread Andy Shevchenko
On Wed, 2016-04-13 at 20:16 +0800, Jisheng Zhang wrote: > Dear Andy, > > On Thu, 7 Apr 2016 21:05:35 +0300 Andy Shevchenko  wrote: > > > > > On Wed, Apr 6, 2016 at 10:28 AM, Jisheng Zhang > > wrote: > > > > > > Sometimes, it's convenient to define the scl's high/low count > > > directly, > > >

Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT

2016-04-13 Thread Jisheng Zhang
Dear Andy, On Thu, 7 Apr 2016 21:05:35 +0300 Andy Shevchenko wrote: > On Wed, Apr 6, 2016 at 10:28 AM, Jisheng Zhang wrote: > > Sometimes, it's convenient to define the scl's high/low count directly, > > e.g HW people would do some measurement then directly give out the > > optimum counts. Prev

Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT

2016-04-13 Thread Jisheng Zhang
Dear Rob, On Thu, 7 Apr 2016 12:57:59 -0500 Rob Herring wrote: > On Wed, Apr 06, 2016 at 03:28:00PM +0800, Jisheng Zhang wrote: > > Sometimes, it's convenient to define the scl's high/low count directly, > > e.g HW people would do some measurement then directly give out the > > optimum counts. Pr

Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT

2016-04-07 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 10:28 AM, Jisheng Zhang wrote: > Sometimes, it's convenient to define the scl's high/low count directly, > e.g HW people would do some measurement then directly give out the > optimum counts. Previously, we solved the sda falling time and scl > falling time by i2c_dw_scl_hcn

Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT

2016-04-07 Thread Rob Herring
On Wed, Apr 06, 2016 at 03:28:00PM +0800, Jisheng Zhang wrote: > Sometimes, it's convenient to define the scl's high/low count directly, > e.g HW people would do some measurement then directly give out the > optimum counts. Previously, we solved the sda falling time and scl > falling time by i2c_dw

[PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT

2016-04-06 Thread Jisheng Zhang
Sometimes, it's convenient to define the scl's high/low count directly, e.g HW people would do some measurement then directly give out the optimum counts. Previously, we solved the sda falling time and scl falling time by i2c_dw_scl_hcnt() and i2c_dw_scl_lcnt(), then put them into dt, but what we r