Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 15:36, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 02:11:33PM +, Peter Rosin wrote: >> Ho hmm. Had another look at this patch, or rather, the context of the >> patch so not really related, but... >> >> On 2018-12-01 11:01, Nicholas Mc Guire wrote: >>> devm_kstrdup() may

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 15:36, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 02:11:33PM +, Peter Rosin wrote: >> Ho hmm. Had another look at this patch, or rather, the context of the >> patch so not really related, but... >> >> On 2018-12-01 11:01, Nicholas Mc Guire wrote: >>> devm_kstrdup() may

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Nicholas Mc Guire
On Tue, Dec 04, 2018 at 02:11:33PM +, Peter Rosin wrote: > Ho hmm. Had another look at this patch, or rather, the context of the > patch so not really related, but... > > On 2018-12-01 11:01, Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed. > > Thus

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Nicholas Mc Guire
On Tue, Dec 04, 2018 at 02:11:33PM +, Peter Rosin wrote: > Ho hmm. Had another look at this patch, or rather, the context of the > patch so not really related, but... > > On 2018-12-01 11:01, Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed. > > Thus

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 15:25, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 01:49:11PM +, Peter Rosin wrote: >> On 2018-12-04 13:13, Nicholas Mc Guire wrote: >>> On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: Hi! This patch looks like a good idea. However, a nitpick

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 15:25, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 01:49:11PM +, Peter Rosin wrote: >> On 2018-12-04 13:13, Nicholas Mc Guire wrote: >>> On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: Hi! This patch looks like a good idea. However, a nitpick

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Nicholas Mc Guire
On Tue, Dec 04, 2018 at 01:49:11PM +, Peter Rosin wrote: > On 2018-12-04 13:13, Nicholas Mc Guire wrote: > > On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: > >> Hi! > >> > >> This patch looks like a good idea. However, a nitpick below. > >> > >> On 2018-12-01 11:01, Nicholas Mc

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Nicholas Mc Guire
On Tue, Dec 04, 2018 at 01:49:11PM +, Peter Rosin wrote: > On 2018-12-04 13:13, Nicholas Mc Guire wrote: > > On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: > >> Hi! > >> > >> This patch looks like a good idea. However, a nitpick below. > >> > >> On 2018-12-01 11:01, Nicholas Mc

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
Ho hmm. Had another look at this patch, or rather, the context of the patch so not really related, but... On 2018-12-01 11:01, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed. > Thus using name, value is unsafe without being checked. As >

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
Ho hmm. Had another look at this patch, or rather, the context of the patch so not really related, but... On 2018-12-01 11:01, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed. > Thus using name, value is unsafe without being checked. As >

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 13:13, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: >> Hi! >> >> This patch looks like a good idea. However, a nitpick below. >> >> On 2018-12-01 11:01, Nicholas Mc Guire wrote: >>> devm_kstrdup() may return NULL if internal allocation

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 13:13, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: >> Hi! >> >> This patch looks like a good idea. However, a nitpick below. >> >> On 2018-12-01 11:01, Nicholas Mc Guire wrote: >>> devm_kstrdup() may return NULL if internal allocation

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Nicholas Mc Guire
On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: > Hi! > > This patch looks like a good idea. However, a nitpick below. > > On 2018-12-01 11:01, Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed. > > Thus using name, value is unsafe without

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Nicholas Mc Guire
On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: > Hi! > > This patch looks like a good idea. However, a nitpick below. > > On 2018-12-01 11:01, Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed. > > Thus using name, value is unsafe without

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Nicholas Mc Guire
On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: > Hi! > > This patch looks like a good idea. However, a nitpick below. > > On 2018-12-01 11:01, Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed. > > Thus using name, value is unsafe without

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Nicholas Mc Guire
On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: > Hi! > > This patch looks like a good idea. However, a nitpick below. > > On 2018-12-01 11:01, Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed. > > Thus using name, value is unsafe without

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
Hi! This patch looks like a good idea. However, a nitpick below. On 2018-12-01 11:01, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed. > Thus using name, value is unsafe without being checked. As > i2c_demux_pinctrl_probe() can return -ENOMEM in other

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
Hi! This patch looks like a good idea. However, a nitpick below. On 2018-12-01 11:01, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed. > Thus using name, value is unsafe without being checked. As > i2c_demux_pinctrl_probe() can return -ENOMEM in other

[PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-01 Thread Nicholas Mc Guire
devm_kstrdup() may return NULL if internal allocation failed. Thus using name, value is unsafe without being checked. As i2c_demux_pinctrl_probe() can return -ENOMEM in other cases a dev_err() message is included to make the failure location clear. Signed-off-by: Nicholas Mc Guire Fixes:

[PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-01 Thread Nicholas Mc Guire
devm_kstrdup() may return NULL if internal allocation failed. Thus using name, value is unsafe without being checked. As i2c_demux_pinctrl_probe() can return -ENOMEM in other cases a dev_err() message is included to make the failure location clear. Signed-off-by: Nicholas Mc Guire Fixes: