Re: [PATCH] i2c: mxs: Better error handling

2013-08-15 Thread Alexandre Belloni
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Wolfram, On 15/08/2013 12:03, Wolfram Sang wrote: > On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote: >> This patch fixes two error handling cases in mxs_i2c_xfer_msg(): >> >> - in PIO mode, mxs_i2c_pio_setup_xfer() may return

Re: [PATCH] i2c: mxs: Better error handling

2013-08-15 Thread Wolfram Sang
On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote: > This patch fixes two error handling cases in mxs_i2c_xfer_msg(): > > - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but i2c->cmd_err > will not be set so mxs_i2c_xfer_msg() fails silently. > > - in DMA mode,

Re: [PATCH] i2c: mxs: Better error handling

2013-08-15 Thread Wolfram Sang
On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote: This patch fixes two error handling cases in mxs_i2c_xfer_msg(): - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but i2c-cmd_err will not be set so mxs_i2c_xfer_msg() fails silently. - in DMA mode,

Re: [PATCH] i2c: mxs: Better error handling

2013-08-15 Thread Alexandre Belloni
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Wolfram, On 15/08/2013 12:03, Wolfram Sang wrote: On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote: This patch fixes two error handling cases in mxs_i2c_xfer_msg(): - in PIO mode, mxs_i2c_pio_setup_xfer() may return an

[PATCH] i2c: mxs: Better error handling

2013-07-03 Thread Alexandre Belloni
This patch fixes two error handling cases in mxs_i2c_xfer_msg(): - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but i2c->cmd_err will not be set so mxs_i2c_xfer_msg() fails silently. - in DMA mode, mxs_i2c_dma_setup_xfer() may return an error and have i2c->cmd_err set to -ENXIO.

[PATCH] i2c: mxs: Better error handling

2013-07-03 Thread Alexandre Belloni
This patch fixes two error handling cases in mxs_i2c_xfer_msg(): - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but i2c-cmd_err will not be set so mxs_i2c_xfer_msg() fails silently. - in DMA mode, mxs_i2c_dma_setup_xfer() may return an error and have i2c-cmd_err set to -ENXIO.