Re: [PATCH] i2c: puv3: Fix an error handling path in puv3_i2c_probe()

2020-05-06 Thread Markus Elfring
> There is a spurious 'put_device()' in the remove function. Do you find differences in the clean-up of system resources suspicious between the implementations of the functions “puv3_i2c_remove” and “puv3_i2c_probe”? Regards, Markus

[PATCH] i2c: puv3: Fix an error handling path in 'puv3_i2c_probe()'

2020-05-05 Thread Christophe JAILLET
There is a spurious 'put_device()' in the remove function. A reference to 'pdev->dev' is taken in the probe function without a corresponding 'get_device()' to increment the refcounted reference. Add the missing 'get_device()' and update the error handling path accordingly. Fixes: d10e4a660d11 ("u