Re: [PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-02 Thread Wolfram Sang
On Wed, Oct 01, 2014 at 10:40:41AM -0700, Alexandru M Stan wrote: > i2cdetect -q was broken (everything was a false positive, and no transfers > were > actually being sent over i2c). The way it works is by sending a 0 length write > request and checking for NACK. This patch fixes the 0 length

Re: [PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-02 Thread Wolfram Sang
> Reviewed-By: Max Schwarz > Tested-By: Max Schwarz Checkpatch says: WARNING: 'Tested-by:' is the preferred signature form Same 'Reviewed-by:' signature.asc Description: Digital signature

Re: [PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-02 Thread Max Schwarz
Hi Alexandru, On Wednesday 01 October 2014 at 10:40:41, Alexandru M Stan wrote: > i2cdetect -q was broken (everything was a false positive, and no transfers > were actually being sent over i2c). The way it works is by sending a 0 > length write request and checking for NACK. This patch fixes the

Re: [PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-02 Thread Wolfram Sang
Reviewed-By: Max Schwarz max.schw...@online.de Tested-By: Max Schwarz max.schw...@online.de Checkpatch says: WARNING: 'Tested-by:' is the preferred signature form Same 'Reviewed-by:' signature.asc Description: Digital signature

Re: [PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-02 Thread Wolfram Sang
On Wed, Oct 01, 2014 at 10:40:41AM -0700, Alexandru M Stan wrote: i2cdetect -q was broken (everything was a false positive, and no transfers were actually being sent over i2c). The way it works is by sending a 0 length write request and checking for NACK. This patch fixes the 0 length writes

Re: [PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-02 Thread Max Schwarz
Hi Alexandru, On Wednesday 01 October 2014 at 10:40:41, Alexandru M Stan wrote: i2cdetect -q was broken (everything was a false positive, and no transfers were actually being sent over i2c). The way it works is by sending a 0 length write request and checking for NACK. This patch fixes the 0

Re: [PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-01 Thread Doug Anderson
Alex, On Wed, Oct 1, 2014 at 10:40 AM, Alexandru M Stan wrote: > i2cdetect -q was broken (everything was a false positive, and no transfers > were > actually being sent over i2c). The way it works is by sending a 0 length write > request and checking for NACK. This patch fixes the 0 length

[PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-01 Thread Alexandru M Stan
i2cdetect -q was broken (everything was a false positive, and no transfers were actually being sent over i2c). The way it works is by sending a 0 length write request and checking for NACK. This patch fixes the 0 length writes and actually sends them. Reported-by: Doug Anderson Signed-off-by:

[PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-01 Thread Alexandru M Stan
i2cdetect -q was broken (everything was a false positive, and no transfers were actually being sent over i2c). The way it works is by sending a 0 length write request and checking for NACK. This patch fixes the 0 length writes and actually sends them. Reported-by: Doug Anderson

Re: [PATCH] i2c: rk3x: fix 0 length write transfers

2014-10-01 Thread Doug Anderson
Alex, On Wed, Oct 1, 2014 at 10:40 AM, Alexandru M Stan ams...@chromium.org wrote: i2cdetect -q was broken (everything was a false positive, and no transfers were actually being sent over i2c). The way it works is by sending a 0 length write request and checking for NACK. This patch fixes