Re: [PATCH] i2c: sh_mobile: Fix compilation warning

2020-06-01 Thread Wolfram Sang
> Almost after an year, wondering on how you reached this patch now :) Another developer sent the same patch. And last time I was unsure if I liked the new code better (for reasons I can't recall anymore); this time it was clear to me. signature.asc Description: PGP signature

Re: [PATCH] i2c: sh_mobile: Fix compilation warning

2020-05-31 Thread Viresh Kumar
On 29-05-20, 14:12, Wolfram Sang wrote: > On Thu, May 09, 2019 at 10:13:46AM +0530, Viresh Kumar wrote: > > This currently generates a warning: > > > > drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr': > > drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used >

Re: [PATCH] i2c: sh_mobile: Fix compilation warning

2020-05-29 Thread Wolfram Sang
On Thu, May 09, 2019 at 10:13:46AM +0530, Viresh Kumar wrote: > This currently generates a warning: > > drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr': > drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used > uninitialized in this function [-Wmaybe-uninitial

[PATCH] i2c: sh_mobile: Fix compilation warning

2019-05-08 Thread Viresh Kumar
This currently generates a warning: drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr': drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized] Though the code looks okay and shouldn't ever use the variable un