Re: Re: [PATCH] i2c: stm32f7: Fix runtime PM imbalance in stm32f7_i2c_reg_slave

2020-05-26 Thread Alain Volmat
On Tue, May 26, 2020 at 09:00:23PM +0800, dinghao@zju.edu.cn wrote: > > > Overall, there are several other calls to pm_runtime_get_sync within this > > driver, would you like to fix them all at once ? > > > > Sure, I will send a new patch to merge them all. Thanks, you might want to add a F

Re: Re: [PATCH] i2c: stm32f7: Fix runtime PM imbalance in stm32f7_i2c_reg_slave

2020-05-26 Thread dinghao . liu
> Overall, there are several other calls to pm_runtime_get_sync within this > driver, would you like to fix them all at once ? > Sure, I will send a new patch to merge them all. > On Thu, May 21, 2020 at 03:05:07PM +0800, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM us

Re: [PATCH] i2c: stm32f7: Fix runtime PM imbalance in stm32f7_i2c_reg_slave

2020-05-26 Thread Alain Volmat
Hi Dinghao, Thanks for the patch. Indeed, this should be fixed. Overall, there are several other calls to pm_runtime_get_sync within this driver, would you like to fix them all at once ? On Thu, May 21, 2020 at 03:05:07PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime P

[PATCH] i2c: stm32f7: Fix runtime PM imbalance in stm32f7_i2c_reg_slave

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/i2c/busses/i2c-stm32f7.c | 4 +++- 1 file changed, 3 insertions(+)