Re: [PATCH] i2c: tegra: Correct error path in probe

2016-07-05 Thread Wolfram Sang
On Tue, Jun 14, 2016 at 09:26:46PM +0100, Jon Hunter wrote: > Commit 497fbe24987b ("i2c: tegra: enable multi master mode for tegra210") > enables the Tegra I2C 'div_clk' for adapters using the multi-master mode > during the device probe. Although the probe error path was updated to > disable the

Re: [PATCH] i2c: tegra: Correct error path in probe

2016-07-05 Thread Wolfram Sang
On Tue, Jun 14, 2016 at 09:26:46PM +0100, Jon Hunter wrote: > Commit 497fbe24987b ("i2c: tegra: enable multi master mode for tegra210") > enables the Tegra I2C 'div_clk' for adapters using the multi-master mode > during the device probe. Although the probe error path was updated to > disable the

Re: [PATCH] i2c: tegra: Correct error path in probe

2016-07-05 Thread Jon Hunter
Wolfram, On 27/06/16 10:32, Laxman Dewangan wrote: > > On Monday 27 June 2016 02:58 PM, Jon Hunter wrote: >> Hi all, >> >> On 14/06/16 21:26, Jon Hunter wrote: >>> @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device >>> *pdev) >>> ret = tegra_i2c_init(i2c_dev); >>>

Re: [PATCH] i2c: tegra: Correct error path in probe

2016-07-05 Thread Jon Hunter
Wolfram, On 27/06/16 10:32, Laxman Dewangan wrote: > > On Monday 27 June 2016 02:58 PM, Jon Hunter wrote: >> Hi all, >> >> On 14/06/16 21:26, Jon Hunter wrote: >>> @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device >>> *pdev) >>> ret = tegra_i2c_init(i2c_dev); >>>

Re: [PATCH] i2c: tegra: Correct error path in probe

2016-06-27 Thread Laxman Dewangan
On Monday 27 June 2016 02:58 PM, Jon Hunter wrote: Hi all, On 14/06/16 21:26, Jon Hunter wrote: @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device *pdev) ret = tegra_i2c_init(i2c_dev); if (ret) { dev_err(>dev, "Failed to initialize i2c

Re: [PATCH] i2c: tegra: Correct error path in probe

2016-06-27 Thread Laxman Dewangan
On Monday 27 June 2016 02:58 PM, Jon Hunter wrote: Hi all, On 14/06/16 21:26, Jon Hunter wrote: @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device *pdev) ret = tegra_i2c_init(i2c_dev); if (ret) { dev_err(>dev, "Failed to initialize i2c

Re: [PATCH] i2c: tegra: Correct error path in probe

2016-06-27 Thread Jon Hunter
Hi all, On 14/06/16 21:26, Jon Hunter wrote: > Commit 497fbe24987b ("i2c: tegra: enable multi master mode for tegra210") > enables the Tegra I2C 'div_clk' for adapters using the multi-master mode > during the device probe. Although the probe error path was updated to > disable the clock on probe

Re: [PATCH] i2c: tegra: Correct error path in probe

2016-06-27 Thread Jon Hunter
Hi all, On 14/06/16 21:26, Jon Hunter wrote: > Commit 497fbe24987b ("i2c: tegra: enable multi master mode for tegra210") > enables the Tegra I2C 'div_clk' for adapters using the multi-master mode > during the device probe. Although the probe error path was updated to > disable the clock on probe

[PATCH] i2c: tegra: Correct error path in probe

2016-06-14 Thread Jon Hunter
Commit 497fbe24987b ("i2c: tegra: enable multi master mode for tegra210") enables the Tegra I2C 'div_clk' for adapters using the multi-master mode during the device probe. Although the probe error path was updated to disable the clock on probe failure, there is one place after calling

[PATCH] i2c: tegra: Correct error path in probe

2016-06-14 Thread Jon Hunter
Commit 497fbe24987b ("i2c: tegra: enable multi master mode for tegra210") enables the Tegra I2C 'div_clk' for adapters using the multi-master mode during the device probe. Although the probe error path was updated to disable the clock on probe failure, there is one place after calling