Re: [PATCH] i386: remove dead code in pgtable_cache_init

2007-10-10 Thread Jeremy Fitzhardinge
Christoph Lameter wrote: > I believe that virtualization support needed a full pgd. > Yes, Xen requires it for PAE pgds, at least at the moment. But native, lguest, vmi and kvm don't. I'd made it so that the memory overhead was only paid in the Xen case. Allocating a whole page all the time

Re: [PATCH] i386: remove dead code in pgtable_cache_init

2007-10-10 Thread Christoph Lameter
On Wed, 10 Oct 2007, Jeremy Fitzhardinge wrote: > The conversion from using a slab cache to quicklist left some residual dead > code. > > I note that in the conversion it now always allocates a whole page for > the pgd, rather than the 32 bytes needed for a PAE pgd. Was this > intended? I beli

[PATCH] i386: remove dead code in pgtable_cache_init

2007-10-10 Thread Jeremy Fitzhardinge
The conversion from using a slab cache to quicklist left some residual dead code. I note that in the conversion it now always allocates a whole page for the pgd, rather than the 32 bytes needed for a PAE pgd. Was this intended? Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Christop