Re: [E1000-devel] [PATCH] i40e: Fix 32 bit shift compilation warnings

2013-08-31 Thread Stephen Hemminger
On Fri, 30 Aug 2013 18:47:35 -0700 Joe Perches wrote: > When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings > Use ((addr>>16) >>16) to avoid this. > > I presume the macro should actually use the kernel.h > macro upper_32_bits() eventually. > > Signed-off-by: Joe Perches > --- > d

Re: [PATCH] i40e: Fix 32 bit shift compilation warnings

2013-08-30 Thread Jeff Kirsher
On Fri, 2013-08-30 at 18:47 -0700, Joe Perches wrote: > When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings > Use ((addr>>16) >>16) to avoid this. > > I presume the macro should actually use the kernel.h > macro upper_32_bits() eventually. > > Signed-off-by: Joe Perches > --- > dri

[PATCH] i40e: Fix 32 bit shift compilation warnings

2013-08-30 Thread Joe Perches
When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings Use ((addr>>16) >>16) to avoid this. I presume the macro should actually use the kernel.h macro upper_32_bits() eventually. Signed-off-by: Joe Perches --- drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 +- drivers/net/ethernet/in