Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

On Thu, 2017-06-29 at 11:28 +0300, Sagi Grimberg wrote: > >> Can you test just the one liner fix below? > >> > @@ -1452,7 +1452,7 @@ > isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc) > { > struct isert_conn *isert_conn = wc->qp->qp_context; > -

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

On Thu, 2017-06-29 at 11:28 +0300, Sagi Grimberg wrote: > >> Can you test just the one liner fix below? > >> > @@ -1452,7 +1452,7 @@ > isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc) > { > struct isert_conn *isert_conn = wc->qp->qp_context; > -

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

Can you test just the one liner fix below? @@ -1452,7 +1452,7 @@ isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc) { struct isert_conn *isert_conn = wc->qp->qp_context; - struct ib_device *ib_dev = isert_conn->cm_id->device; + struct ib_device *ib_dev =

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

Can you test just the one liner fix below? @@ -1452,7 +1452,7 @@ isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc) { struct isert_conn *isert_conn = wc->qp->qp_context; - struct ib_device *ib_dev = isert_conn->cm_id->device; + struct ib_device *ib_dev =

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

On Thu, Jun 29, 2017 at 08:36:51AM +0300, Sagi Grimberg wrote: > > >Just tested this patch, I wasn't able to reproduce the NULL pointer > >dereference or any other bugs, so this fix seems safe enough to me. > > > >Tested-by: Andrea Righi > > Can you test just the one

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

On Thu, Jun 29, 2017 at 08:36:51AM +0300, Sagi Grimberg wrote: > > >Just tested this patch, I wasn't able to reproduce the NULL pointer > >dereference or any other bugs, so this fix seems safe enough to me. > > > >Tested-by: Andrea Righi > > Can you test just the one liner fix below? > > >>@@

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

Just tested this patch, I wasn't able to reproduce the NULL pointer dereference or any other bugs, so this fix seems safe enough to me. Tested-by: Andrea Righi Can you test just the one liner fix below? @@ -1452,7 +1452,7 @@ isert_login_recv_done(struct ib_cq

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

Just tested this patch, I wasn't able to reproduce the NULL pointer dereference or any other bugs, so this fix seems safe enough to me. Tested-by: Andrea Righi Can you test just the one liner fix below? @@ -1452,7 +1452,7 @@ isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc) {

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

On Sun, Jun 25, 2017 at 04:58:04PM -0700, Nicholas A. Bellinger wrote: ... > So I assume isert_cma_handler() -> isert_connect_error() getting called > to clear isert_conn->cm_id before connection established, and > subsequently isert_conn->login_req_buf->rx_cqe.done() -> > isert_login_recv_done()

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

On Sun, Jun 25, 2017 at 04:58:04PM -0700, Nicholas A. Bellinger wrote: ... > So I assume isert_cma_handler() -> isert_connect_error() getting called > to clear isert_conn->cm_id before connection established, and > subsequently isert_conn->login_req_buf->rx_cqe.done() -> > isert_login_recv_done()

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

Hi Andrea & Robert, Hi Andrea, Robert, Nic and Co We have hit this four times today. Any ideas? [ 169.382113] BUG: unable to handle kernel NULL pointer dereference at (null) [ 169.382152] IP: [] isert_login_recv_done+0x28/0x170 [ib_isert] So, we spent more time to track down

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done()

Hi Andrea & Robert, Hi Andrea, Robert, Nic and Co We have hit this four times today. Any ideas? [ 169.382113] BUG: unable to handle kernel NULL pointer dereference at (null) [ 169.382152] IP: [] isert_login_recv_done+0x28/0x170 [ib_isert] So, we spent more time to track down

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

On Fri, Jun 23, 2017 at 12:37:57AM +0200, Andrea Righi wrote: > On Wed, Jun 21, 2017 at 10:33:45AM -0600, Robert LeBlanc wrote: > > On Wed, Jun 21, 2017 at 9:17 AM, Robert LeBlanc > > wrote: > > > On Tue, Jun 20, 2017 at 12:54 PM, Robert LeBlanc > >

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

On Fri, Jun 23, 2017 at 12:37:57AM +0200, Andrea Righi wrote: > On Wed, Jun 21, 2017 at 10:33:45AM -0600, Robert LeBlanc wrote: > > On Wed, Jun 21, 2017 at 9:17 AM, Robert LeBlanc > > wrote: > > > On Tue, Jun 20, 2017 at 12:54 PM, Robert LeBlanc > > > wrote: > > >> We have hit this four times

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

Hi Andrea & Robert, (Adding HCH CC') On Fri, 2017-06-23 at 00:37 +0200, Andrea Righi wrote: > On Wed, Jun 21, 2017 at 10:33:45AM -0600, Robert LeBlanc wrote: > > On Wed, Jun 21, 2017 at 9:17 AM, Robert LeBlanc > > wrote: > > > On Tue, Jun 20, 2017 at 12:54 PM, Robert

Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

Hi Andrea & Robert, (Adding HCH CC') On Fri, 2017-06-23 at 00:37 +0200, Andrea Righi wrote: > On Wed, Jun 21, 2017 at 10:33:45AM -0600, Robert LeBlanc wrote: > > On Wed, Jun 21, 2017 at 9:17 AM, Robert LeBlanc > > wrote: > > > On Tue, Jun 20, 2017 at 12:54 PM, Robert LeBlanc > > > wrote: > >

[PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

On Wed, Jun 21, 2017 at 10:33:45AM -0600, Robert LeBlanc wrote: > On Wed, Jun 21, 2017 at 9:17 AM, Robert LeBlanc wrote: > > On Tue, Jun 20, 2017 at 12:54 PM, Robert LeBlanc > > wrote: > >> We have hit this four times today. Any ideas? > >> > >> [

[PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32)

On Wed, Jun 21, 2017 at 10:33:45AM -0600, Robert LeBlanc wrote: > On Wed, Jun 21, 2017 at 9:17 AM, Robert LeBlanc wrote: > > On Tue, Jun 20, 2017 at 12:54 PM, Robert LeBlanc > > wrote: > >> We have hit this four times today. Any ideas? > >> > >> [ 169.382113] BUG: unable to handle kernel NULL