On Fri, 11 Sep 2020, Geert Uytterhoeven wrote:
>
> Sorry, I completely missed that the Baboon case registers a
> "pata_platform" device instead of a "macide" device. Hence please
> ignore my comments related to that. Sorry for the noise.
>
No problem. That misunderstanding got me thinking a
Hi Finn,
On Fri, Sep 11, 2020 at 1:05 AM Finn Thain wrote:
> On Thu, 10 Sep 2020, Geert Uytterhoeven wrote:
> > On Thu, Sep 10, 2020 at 2:23 AM Finn Thain
> > wrote:
> > > > How does the driver know not to use the special port_ops after
> > > > this change?
> > > >
> > >
> > > The driver always
On Thu, 10 Sep 2020, Geert Uytterhoeven wrote:
> On Thu, Sep 10, 2020 at 2:23 AM Finn Thain wrote:
> > I prefer a declarative or data-driven style, even if it takes a few
> > more lines of code. But there is a compromise:
> >
> > static const struct resource mac_ide_quadra_rsrc[] __initconst = {
Hi Finn,
On Thu, Sep 10, 2020 at 2:23 AM Finn Thain wrote:
> On Wed, 9 Sep 2020, Geert Uytterhoeven wrote:
> > > --- a/arch/m68k/mac/config.c +++ b/arch/m68k/mac/config.c
> >
> > > @@ -940,6 +941,50 @@ static const struct resource mac_scsi_ccl_rsrc[]
> > > __initconst = {
> > > },
> > >
Hi Finn,
Am 10.09.2020 um 12:23 schrieb Finn Thain:
+ return 0;
+
+release_mem:
+ release_mem_region(mem->start, resource_size(mem));
Not needed, as you used devm_*() for allocation.
OK, I'll remove this. I put it there after I looked at falconide.c and
wondered whether the auto
On Wed, 9 Sep 2020, Geert Uytterhoeven wrote:
>
> Thanks for your patch!
>
Thanks for your review.
> > --- a/arch/m68k/mac/config.c +++ b/arch/m68k/mac/config.c
>
> > @@ -940,6 +941,50 @@ static const struct resource mac_scsi_ccl_rsrc[]
> > __initconst = {
> > },
> > };
> >
> > +sta
Hi Finn,
On Tue, Aug 18, 2020 at 9:45 AM Finn Thain wrote:
> Add platform devices for the Mac IDE controller variants. Convert the
> macide module into a platform driver to support two of those variants.
> For the third, use a generic "pata_platform" driver instead.
> This enables automatic loadi
Add platform devices for the Mac IDE controller variants. Convert the
macide module into a platform driver to support two of those variants.
For the third, use a generic "pata_platform" driver instead.
This enables automatic loading of the appropriate module and begins
the process of replacing the
8 matches
Mail list logo
