Re: [PATCH] ide-disk oopses on boot

2005-08-10 Thread Christoph Lameter
On Wed, 10 Aug 2005, Alan Cox wrote: > On Maw, 2005-08-09 at 19:59 -0700, Christoph Lameter wrote: > > Yes you are right there is one additional place where pcibus_to_node is > > used with the hwif that we did not cover. This better go into 2.6.13. > > drive->hwif is not permitted to be NULL. Pl

Re: [PATCH] ide-disk oopses on boot

2005-08-10 Thread Alan Cox
On Maw, 2005-08-09 at 19:59 -0700, Christoph Lameter wrote: > Yes you are right there is one additional place where pcibus_to_node is > used with the hwif that we did not cover. This better go into 2.6.13. drive->hwif is not permitted to be NULL. Please work back and fix the actual bug. > - To

Re: [PATCH] ide-disk oopses on boot

2005-08-10 Thread Bartlomiej Zolnierkiewicz
Why have you removed me from cc:? On 8/10/05, Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Wed, 10 Aug 2005, Petr Vandrovec wrote: > > > > Yes that was discussed extensively by Andi and me and finally fixed by > > > Kiran's patch in 2.6.13-rc6. > > > > By which patch? I hit it with post-2.6

Re: [PATCH] ide-disk oopses on boot

2005-08-09 Thread Christoph Lameter
On Wed, 10 Aug 2005, Petr Vandrovec wrote: > > Yes that was discussed extensively by Andi and me and finally fixed by > > Kiran's patch in 2.6.13-rc6. > > By which patch? I hit it with post-2.6.13-rc6, exactly 2.6.13-rc6 with > checkin hash "commit 00dd1e433967872f3997a45d5adf35056fdf2f56". So

Re: [PATCH] ide-disk oopses on boot

2005-08-09 Thread Christoph Lameter
On Tue, 9 Aug 2005, Petr Vandrovec wrote: > Problem is that pci_dev may be NULL - and it is NULL for example with > kernel I've just built, with amd IDE driver built as a module while with > ide-disk built into the kernel. Yes that was discussed extensively by Andi and me and finally fixed by

[PATCH] ide-disk oopses on boot

2005-08-09 Thread Petr Vandrovec
Hello Christoph, back in June your '[PATCH] NUMA aware block device control structure allocation' patch went in, changing ide-disk.c's code: - g = alloc_disk(1 << PARTN_BITS); + g = alloc_disk_node(1 << PARTN_BITS, + pcibus_to_node(drive->hwif->pci_dev->bus)); Probl