Re: [PATCH] idr: explain WARN_ON_ONCE() on negative IDs out-of-range ID

2013-02-21 Thread Thomas Gleixner
On Wed, 20 Feb 2013, Tejun Heo wrote: > Until recently, when an negative ID is specified, idr functions used > to ignore the sign bit and proceeded with the operation with the rest > of bits, which is bizarre and error-prone. The behavior recently got > changed so that negative IDs are treated as

[PATCH] idr: explain WARN_ON_ONCE() on negative IDs out-of-range ID

2013-02-20 Thread Tejun Heo
Until recently, when an negative ID is specified, idr functions used to ignore the sign bit and proceeded with the operation with the rest of bits, which is bizarre and error-prone. The behavior recently got changed so that negative IDs are treated as invalid but we're triggering WARN_ON_ONCE() on