Re: [PATCH] ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'

2019-09-24 Thread Stefan Schmidt
Hello. On 24.09.19 23:40, Xue Liu wrote: On Sat, 21 Sep 2019 at 13:52, Stefan Schmidt wrote: Hello Xue. On 20.09.19 21:45, Christophe JAILLET wrote: Use a 'skb_put_data()' variant instead of rewritting it. The __skb_put_data variant is safe here. It is obvious that the skb can not overflow.

Re: [PATCH] ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'

2019-09-24 Thread Xue Liu
On Sat, 21 Sep 2019 at 13:52, Stefan Schmidt wrote: > > Hello Xue. > > On 20.09.19 21:45, Christophe JAILLET wrote: > > Use a 'skb_put_data()' variant instead of rewritting it. > > The __skb_put_data variant is safe here. It is obvious that the skb can > > not overflow. It has just been allocated

Re: [PATCH] ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'

2019-09-21 Thread Stefan Schmidt
Hello Xue. On 20.09.19 21:45, Christophe JAILLET wrote: > Use a 'skb_put_data()' variant instead of rewritting it. > The __skb_put_data variant is safe here. It is obvious that the skb can > not overflow. It has just been allocated a few lines above with the same > 'len'. > > Signed-off-by: Chris

[PATCH] ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'

2019-09-20 Thread Christophe JAILLET
Use a 'skb_put_data()' variant instead of rewritting it. The __skb_put_data variant is safe here. It is obvious that the skb can not overflow. It has just been allocated a few lines above with the same 'len'. Signed-off-by: Christophe JAILLET --- drivers/net/ieee802154/mcr20a.c | 2 +- 1 file ch