RE: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-14 Thread Keller, Jacob E
ge.net; net...@vger.kernel.org > Subject: Re: [PATCH] igb: add a method to get the nic hw time stamping > policy > > Hi, > > > I modified this patch and added the method to igb_get_ts_info > function. > > For 82576 nic, through this method we can easily che

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-14 Thread Peter P Waskiewicz Jr
On 05/14/2013 02:51 AM, Dong Zhu wrote: Hi, I modified this patch and added the method to igb_get_ts_info function. For 82576 nic, through this method we can easily check which type of packets are time stamped now, such as (HWTSTAMP_FILTER_PTP_V1_L4_SYNC and HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ)

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-14 Thread Dong Zhu
Hi, > I modified this patch and added the method to igb_get_ts_info function. > For 82576 nic, through this method we can easily check which type of packets > are time stamped now, such as (HWTSTAMP_FILTER_PTP_V1_L4_SYNC and > HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ), then change or disable it up to y

RE: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-13 Thread Keller, Jacob E
wicz > Jr, Peter P; Duyck, Alexander H; Ronciak, John; Dave, Tushar N; Vick, > Matthew; Keller, Jacob E; Paul E. McKenney; David Howells; Dave Jones; > Thomas Gleixner; linux-kernel@vger.kernel.org; e1000- > de...@lists.sourceforge.net; net...@vger.kernel.org > Subject: Re: [PATCH] ig

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-13 Thread Ben Hutchings
On Mon, 2013-05-13 at 15:48 +, Vick, Matthew wrote: > On 5/13/13 3:07 AM, "Dong Zhu" wrote: [...] > >From 8a12932fd2a3bb5ca904bc72b20140247a5d81be Mon Sep 17 00:00:00 2001 > >From: Dong Zhu > >Date: Mon, 13 May 2013 17:27:59 +0800 > > > >Currently kernel only support setting the hw time stamp

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-13 Thread Vick, Matthew
On 5/13/13 3:07 AM, "Dong Zhu" wrote: >> You could use the flags field, as it has no definition yet. >> >> But you still need to explain why this new functionality is needed in >> the first place: >> >> - You can query an interface's time stamping capabilities with the >> GET_TS_INFO ethtool

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-13 Thread Dong Zhu
> You could use the flags field, as it has no definition yet. > > But you still need to explain why this new functionality is needed in > the first place: > > - You can query an interface's time stamping capabilities with the > GET_TS_INFO ethtool command. > Hi, I modified this patch and add

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-12 Thread Richard Cochran
On Mon, May 13, 2013 at 10:12:36AM +0800, Dong Zhu wrote: > > Can I use the 'flags' which members of hwtstamp_config to judge the > ioctl request instead ? If not could you plz give me a new way to > resolve this issue ? You could use the flags field, as it has no definition yet. But you still n

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-12 Thread Dong Zhu
On Sun, May 12, 2013 at 07:24:46PM +0200, Richard Cochran wrote: > On Sun, May 12, 2013 at 10:25:55PM +0800, Dong Zhu wrote: > > Thanks for your pointing out my mistakes of CodingStyle. > > > > > > struct hwtstamp_config { > > > >+int rw; > > > > My initial idea was that the type of rw sh

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-12 Thread Richard Cochran
On Sun, May 12, 2013 at 10:25:55PM +0800, Dong Zhu wrote: > Thanks for your pointing out my mistakes of CodingStyle. > > > > struct hwtstamp_config { > > >+ int rw; > > My initial idea was that the type of rw should be enum like tx_type, but I am > not sure whther it is necessary to define a new

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-12 Thread Dong Zhu
Thanks for your pointing out my mistakes of CodingStyle. > > struct hwtstamp_config { > >+int rw; My initial idea was that the type of rw should be enum like tx_type, but I am not sure whther it is necessary to define a new enum, if this patch could be accpeted I will ask someone about the rw

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-12 Thread Dong Zhu
On Sat, May 11, 2013 at 05:31:43PM +0200, Richard Cochran wrote: > On Sat, May 11, 2013 at 10:02:19PM +0800, Dong Zhu wrote: > > > > Currently kernel only support setting the hw time stamping policy > > through ioctl,now add a method to check which packets(Outgoing and > > Incoming) are time stamp

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-11 Thread Sergei Shtylyov
Hello. On 11-05-2013 18:02, Dong Zhu wrote: From e6a55411486de8a09b859e73140bf35c0ee36047 Mon Sep 17 00:00:00 2001 From: Dong Zhu Date: Sat, 11 May 2013 21:44:54 +0800 Subject: [PATCH] igb: add a method to get the nic hw time stamping policy Please, don't send this header with

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-11 Thread Richard Cochran
On Sat, May 11, 2013 at 10:02:19PM +0800, Dong Zhu wrote: > > Currently kernel only support setting the hw time stamping policy > through ioctl,now add a method to check which packets(Outgoing and > Incoming) are time stamped by nic. I don't really see a use case here. Applications needing time s

[PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-11 Thread Dong Zhu
>From e6a55411486de8a09b859e73140bf35c0ee36047 Mon Sep 17 00:00:00 2001 From: Dong Zhu Date: Sat, 11 May 2013 21:44:54 +0800 Subject: [PATCH] igb: add a method to get the nic hw time stamping policy Currently kernel only support setting the hw time stamping policy through ioctl,now add a met