Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-05-02 Thread Jonathan Cameron
On 29/04/15 12:27, Gabriele Mazzotta wrote: > Add basic implementation of the ACPI0008 Ambient Light Sensor driver. > This driver currently supports only the ALI property, yet is ready to > be easily extended to handle ALC, ALT, ALP ones as well. > > Signed-off-by: Martin Liska > Signed-off-by: M

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-05-02 Thread Jonathan Cameron
On 01/05/15 17:12, Gabriele Mazzotta wrote: > Hi, > > probably this is not completely related to this driver, but I > noticed something while testing it. > > When I load acpi-als, /sys/bus/iio/devices/iio:device0/buffer/enable > is 0. If I try to set it to 1, I get the following error: > "Buffer

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-05-01 Thread Gabriele Mazzotta
Hi, probably this is not completely related to this driver, but I noticed something while testing it. When I load acpi-als, /sys/bus/iio/devices/iio:device0/buffer/enable is 0. If I try to set it to 1, I get the following error: "Buffer not started: buffer parameter update failed (-22)" After I

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Marek Vasut
On Thursday, April 30, 2015 at 10:33:46 PM, Paul Bolle wrote: > Just a nit: a license mismatch. > > On Wed, 2015-04-29 at 13:27 +0200, Gabriele Mazzotta wrote: > > --- /dev/null > > +++ b/drivers/iio/light/acpi-als.c > > > > + * This program is free software; you can redistribute it and/or modify

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Paul Bolle
Just a nit: a license mismatch. On Wed, 2015-04-29 at 13:27 +0200, Gabriele Mazzotta wrote: > --- /dev/null > +++ b/drivers/iio/light/acpi-als.c > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, >

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Gabriele Mazzotta
On Thursday 30 April 2015 15:24:07 Daniel Baluta wrote: > Hi Gabriele, > > Please keep the version numbering from previous patches, > I think this should be v8 :). OK, I'll use v9 for the next submission. > On Wed, Apr 29, 2015 at 2:27 PM, Gabriele Mazzotta > wrote: > > Add basic implementation

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Daniel Baluta
Hi Gabriele, Please keep the version numbering from previous patches, I think this should be v8 :). On Wed, Apr 29, 2015 at 2:27 PM, Gabriele Mazzotta wrote: > Add basic implementation of the ACPI0008 Ambient Light Sensor driver. > This driver currently supports only the ALI property, yet is rea

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Marek Vasut
On Thursday, April 30, 2015 at 01:27:43 PM, Gabriele Mazzotta wrote: > On Thursday 30 April 2015 11:44:36 Marek Vasut wrote: > > On Wednesday, April 29, 2015 at 05:36:32 PM, Gabriele Mazzotta wrote: > > [...] > > > > > > > I'm sorry, I've just noticed that I haven't changed the value of > > > > >

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Gabriele Mazzotta
On Thursday 30 April 2015 11:44:36 Marek Vasut wrote: > On Wednesday, April 29, 2015 at 05:36:32 PM, Gabriele Mazzotta wrote: > [...] > > > > I'm sorry, I've just noticed that I haven't changed the value of > > > > realbits in acpi_als_channels. This makes me wonder what would be the > > > > proper

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Marek Vasut
On Wednesday, April 29, 2015 at 05:36:32 PM, Gabriele Mazzotta wrote: [...] > > > I'm sorry, I've just noticed that I haven't changed the value of > > > realbits in acpi_als_channels. This makes me wonder what would be the > > > proper value, given that this is a generic driver and all the > > > in

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-29 Thread Gabriele Mazzotta
On Wednesday 29 April 2015 16:33:18 Marek Vasut wrote: > On Wednesday, April 29, 2015 at 01:51:21 PM, Gabriele Mazzotta wrote: > > On Wednesday 29 April 2015 13:27:25 Gabriele Mazzotta wrote: > > > Add basic implementation of the ACPI0008 Ambient Light Sensor driver. > > > This driver currently sup

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-29 Thread Marek Vasut
On Wednesday, April 29, 2015 at 01:51:21 PM, Gabriele Mazzotta wrote: > On Wednesday 29 April 2015 13:27:25 Gabriele Mazzotta wrote: > > Add basic implementation of the ACPI0008 Ambient Light Sensor driver. > > This driver currently supports only the ALI property, yet is ready to > > be easily exte

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-29 Thread Gabriele Mazzotta
On Wednesday 29 April 2015 13:27:25 Gabriele Mazzotta wrote: > Add basic implementation of the ACPI0008 Ambient Light Sensor driver. > This driver currently supports only the ALI property, yet is ready to > be easily extended to handle ALC, ALT, ALP ones as well. > > Signed-off-by: Martin Liska >

[PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-29 Thread Gabriele Mazzotta
Add basic implementation of the ACPI0008 Ambient Light Sensor driver. This driver currently supports only the ALI property, yet is ready to be easily extended to handle ALC, ALT, ALP ones as well. Signed-off-by: Martin Liska Signed-off-by: Marek Vasut Signed-off-by: Gabriele Mazzotta Cc: Zhang