Re: [PATCH] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-05 Thread dmitry . torokhov
On Mon, Oct 05, 2020 at 09:00:10PM +0200, Michał Mirosław wrote: > On Mon, Oct 05, 2020 at 10:36:36AM -0700, dmitry.torok...@gmail.com wrote: > > Hi Michał, > > > > On Mon, Oct 05, 2020 at 01:09:08PM +0200, Michał Mirosław wrote: > > > and breaking the loop will desync touch > > > state (I would

Re: [PATCH] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-05 Thread Michał Mirosław
On Mon, Oct 05, 2020 at 10:36:36AM -0700, dmitry.torok...@gmail.com wrote: > Hi Michał, > > On Mon, Oct 05, 2020 at 01:09:08PM +0200, Michał Mirosław wrote: > > On Sun, Oct 04, 2020 at 10:24:20PM -0700, dmitry.torok...@gmail.com wrote: > > > The order in which 'users' counter is decremented vs

Re: [PATCH] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-05 Thread dmitry . torokhov
Hi Michał, On Mon, Oct 05, 2020 at 01:09:08PM +0200, Michał Mirosław wrote: > On Sun, Oct 04, 2020 at 10:24:20PM -0700, dmitry.torok...@gmail.com wrote: > > The order in which 'users' counter is decremented vs calling drivers' > > close() method is implementation specific, and we should not rely

Re: [PATCH] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-05 Thread Michał Mirosław
On Sun, Oct 04, 2020 at 10:24:20PM -0700, dmitry.torok...@gmail.com wrote: > The order in which 'users' counter is decremented vs calling drivers' > close() method is implementation specific, and we should not rely on > it. Let's introduce driver private flag and use it to signal ISR > to exit

Re: [PATCH] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-05 Thread Krzysztof Kozlowski
On Sun, Oct 04, 2020 at 10:24:20PM -0700, dmitry.torok...@gmail.com wrote: > The order in which 'users' counter is decremented vs calling drivers' > close() method is implementation specific, and we should not rely on > it. Let's introduce driver private flag and use it to signal ISR > to exit

[PATCH] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-04 Thread dmitry . torokhov
The order in which 'users' counter is decremented vs calling drivers' close() method is implementation specific, and we should not rely on it. Let's introduce driver private flag and use it to signal ISR to exit when device is being closed. This has a side-effect of fixing issue of accessing