Re: [PATCH] iio: cm36651: Fix i2c client leak and possible NULL pointer dereference

2014-03-18 Thread Krzysztof Kozlowski
On Mon, 2014-03-17 at 19:24 +, Jonathan Cameron wrote: > On 17/03/14 08:01, Krzysztof Kozlowski wrote: > > Hi, > > > > On Sat, 2014-03-15 at 16:24 +, Jonathan Cameron wrote: > >> On 06/03/14 09:33, Krzysztof Kozlowski wrote: > >>> During probe the driver allocates dummy I2C devices (i2c_new

Re: [PATCH] iio: cm36651: Fix i2c client leak and possible NULL pointer dereference

2014-03-17 Thread Jonathan Cameron
On 17/03/14 08:01, Krzysztof Kozlowski wrote: Hi, On Sat, 2014-03-15 at 16:24 +, Jonathan Cameron wrote: On 06/03/14 09:33, Krzysztof Kozlowski wrote: During probe the driver allocates dummy I2C devices (i2c_new_dummy()) but they aren't unregistered during driver remove or probe failure.

Re: [PATCH] iio: cm36651: Fix i2c client leak and possible NULL pointer dereference

2014-03-17 Thread Krzysztof Kozlowski
Hi, On Sat, 2014-03-15 at 16:24 +, Jonathan Cameron wrote: > On 06/03/14 09:33, Krzysztof Kozlowski wrote: > > During probe the driver allocates dummy I2C devices (i2c_new_dummy()) > > but they aren't unregistered during driver remove or probe failure. > > > > Additionally driver does not chec

Re: [PATCH] iio: cm36651: Fix i2c client leak and possible NULL pointer dereference

2014-03-15 Thread Jonathan Cameron
On 06/03/14 09:33, Krzysztof Kozlowski wrote: During probe the driver allocates dummy I2C devices (i2c_new_dummy()) but they aren't unregistered during driver remove or probe failure. Additionally driver does not check the return value of i2c_new_dummy(). In case of error (i2c_new_device(): memo

Re: [PATCH] iio: cm36651: Fix i2c client leak and possible NULL pointer dereference

2014-03-06 Thread Beomho Seo
On 03/06/2014 06:33 PM, Krzysztof Kozlowski wrote: > During probe the driver allocates dummy I2C devices (i2c_new_dummy()) > but they aren't unregistered during driver remove or probe failure. > > Additionally driver does not check the return value of i2c_new_dummy(). > In case of error (i2c_new_d

[PATCH] iio: cm36651: Fix i2c client leak and possible NULL pointer dereference

2014-03-06 Thread Krzysztof Kozlowski
During probe the driver allocates dummy I2C devices (i2c_new_dummy()) but they aren't unregistered during driver remove or probe failure. Additionally driver does not check the return value of i2c_new_dummy(). In case of error (i2c_new_device(): memory allocation failure or I2C address cannot be u