Re: [PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-05 Thread Lars-Peter Clausen
On 08/05/2016 01:37 AM, Alison Schofield wrote: [...] > > No, that's not what this bug & patch is about. > > This patch is about the fact that we are reading the temp & > humid data registers incorrectly in the current driver and > we are exposing incorrect numbers via sysfs raw reads. > > I hav

Re: [PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-04 Thread Alison Schofield
On Thu, Aug 04, 2016 at 03:21:13PM -0700, Matt Ranostay wrote: > On Thu, Aug 4, 2016 at 8:35 AM, Alison Schofield wrote: > > On Wed, Aug 03, 2016 at 10:50:54PM -0700, Matt Ranostay wrote: > >> On Wed, Aug 3, 2016 at 10:19 PM, Peter Meerwald-Stadler > >> wrote: > >> > >> > > >> > > > Replace the i

Re: [PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-04 Thread Matt Ranostay
On Thu, Aug 4, 2016 at 8:35 AM, Alison Schofield wrote: > On Wed, Aug 03, 2016 at 10:50:54PM -0700, Matt Ranostay wrote: >> On Wed, Aug 3, 2016 at 10:19 PM, Peter Meerwald-Stadler >> wrote: >> >> > >> > > > Replace the i2c_smbus_read_byte commmands used to retrieve the sensor >> > > > data with a

Re: [PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-04 Thread Alison Schofield
On Wed, Aug 03, 2016 at 10:50:54PM -0700, Matt Ranostay wrote: > On Wed, Aug 3, 2016 at 10:19 PM, Peter Meerwald-Stadler > wrote: > > > > > > > Replace the i2c_smbus_read_byte commmands used to retrieve the sensor > > > > data with an i2c_master_recv command. > > > > > > > > The smbus read byte m

Re: [PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-03 Thread Peter Meerwald-Stadler
> > Replace the i2c_smbus_read_byte commmands used to retrieve the sensor > > data with an i2c_master_recv command. > > > > The smbus read byte method fails because the device does not expect a > > stop condition after sending the first byte. When we issue the second > > read, we are getting the f

Re: [PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-03 Thread Matt Ranostay
On Wed, Aug 3, 2016 at 8:33 PM, Alison Schofield wrote: > Replace the i2c_smbus_read_byte commmands used to retrieve the sensor > data with an i2c_master_recv command. > > The smbus read byte method fails because the device does not expect a > stop condition after sending the first byte. When we i

[PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-03 Thread Alison Schofield
Replace the i2c_smbus_read_byte commmands used to retrieve the sensor data with an i2c_master_recv command. The smbus read byte method fails because the device does not expect a stop condition after sending the first byte. When we issue the second read, we are getting the first byte again. Net eff