Re: [PATCH] iio: light: isl29501: Simplify code to kill compiler warning

2018-09-02 Thread Geert Uytterhoeven
Hi Jonathan, On Sun, Sep 2, 2018 at 10:59 AM Jonathan Cameron wrote: > On Sat, 25 Aug 2018 09:30:55 +0100 > Jonathan Cameron wrote: > > > On Thu, 23 Aug 2018 23:24:35 +0200 > > Geert Uytterhoeven wrote: > > > > > With gcc 4.1.2: > > > > > > drivers/iio/proximity/isl29501.c: In function > >

Re: [PATCH] iio: light: isl29501: Simplify code to kill compiler warning

2018-09-02 Thread Jonathan Cameron
On Sat, 25 Aug 2018 09:30:55 +0100 Jonathan Cameron wrote: > On Thu, 23 Aug 2018 23:24:35 +0200 > Geert Uytterhoeven wrote: > > > With gcc 4.1.2: > > > > drivers/iio/proximity/isl29501.c: In function ‘isl29501_register_write’: > > drivers/iio/proximity/isl29501.c:235: warning: ‘msb’ ma

Re: [PATCH] iio: light: isl29501: Simplify code to kill compiler warning

2018-08-25 Thread Jonathan Cameron
On Thu, 23 Aug 2018 23:24:35 +0200 Geert Uytterhoeven wrote: > With gcc 4.1.2: > > drivers/iio/proximity/isl29501.c: In function ‘isl29501_register_write’: > drivers/iio/proximity/isl29501.c:235: warning: ‘msb’ may be used > uninitialized in this function > > While this is a false posi

[PATCH] iio: light: isl29501: Simplify code to kill compiler warning

2018-08-23 Thread Geert Uytterhoeven
With gcc 4.1.2: drivers/iio/proximity/isl29501.c: In function ‘isl29501_register_write’: drivers/iio/proximity/isl29501.c:235: warning: ‘msb’ may be used uninitialized in this function While this is a false positive, it can easily be avoided by removing the "msb" intermediate variable. R