On 01/04/16 09:28, Daniel Baluta wrote:
>> .wipers and .max_pos need not be in max5487_cfg, they are common.
>> .wipers isn't even used. Which means that if you like, you can
>> use the ohms reading as the driver_data directly instead of going
>> via the MAX548x enumeration, see below. Or is there
On Fri, Mar 25, 2016 at 12:20 PM, Peter Rosin wrote:
> Hi again,
>
> Cristina Moraru wrote:
>> Add implementation for Maxim MAX5487, MAX5488, MAX5489
>> digital potentiometers.
>>
>> Signed-off-by: Cristina Moraru
>> CC: Daniel Baluta
>
> Some more comments, the mcp4531 chips have n**2 + 1 posit
> .wipers and .max_pos need not be in max5487_cfg, they are common.
> .wipers isn't even used. Which means that if you like, you can
> use the ohms reading as the driver_data directly instead of going
> via the MAX548x enumeration, see below. Or is there some reason
> not doing so?
You make a good
Hi again,
Cristina Moraru wrote:
> Add implementation for Maxim MAX5487, MAX5488, MAX5489
> digital potentiometers.
>
> Signed-off-by: Cristina Moraru
> CC: Daniel Baluta
Some more comments, the mcp4531 chips have n**2 + 1 positions,
therefore .max_pos in that driver isn't the number of wiper
Hi Cristina,
Some comments inline...
Cheers,
Peter
Cristina Moraru wrote:
> Add implementation for Maxim MAX5487, MAX5488, MAX5489
> digital potentiometers.
>
> Signed-off-by: Cristina Moraru
> CC: Daniel Baluta
> ---
> drivers/iio/potentiometer/Kconfig | 11 +++
> drivers/iio/potentiomet
On Thu, Mar 24, 2016 at 1:21 PM, Cristina Moraru
wrote:
> Add implementation for Maxim MAX5487, MAX5488, MAX5489
> digital potentiometers.
Datasheet: http://datasheets.maximintegrated.com/en/ds/MAX5487-MAX5489.pdf
>
> Signed-off-by: Cristina Moraru
> CC: Daniel Baluta
Tested-by: Daniel Baluta
Add implementation for Maxim MAX5487, MAX5488, MAX5489
digital potentiometers.
Signed-off-by: Cristina Moraru
CC: Daniel Baluta
---
drivers/iio/potentiometer/Kconfig | 11 +++
drivers/iio/potentiometer/Makefile | 1 +
drivers/iio/potentiometer/max5487.c | 185 +
7 matches
Mail list logo