Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

2016-12-30 Thread Stefan Wahren
> Jonathan Cameron hat am 30. Dezember 2016 um 20:09 > geschrieben: > > > On 26/12/16 22:04, Stefan Wahren wrote: > > > >> Alexey Khoroshilov hat am 23. Dezember 2016 um > >> 23:15 geschrieben: > >> > >> > >> During transition to using devm_input_allocate_device() > >> goto to resource deall

Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

2016-12-30 Thread Jonathan Cameron
On 26/12/16 22:04, Stefan Wahren wrote: > >> Alexey Khoroshilov hat am 23. Dezember 2016 um 23:15 >> geschrieben: >> >> >> During transition to using devm_input_allocate_device() >> goto to resource deallocation block was replaced by return >> in case of error in iio_device_register(). >> That i

Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

2016-12-26 Thread Stefan Wahren
> Alexey Khoroshilov hat am 23. Dezember 2016 um 23:15 > geschrieben: > > > During transition to using devm_input_allocate_device() > goto to resource deallocation block was replaced by return > in case of error in iio_device_register(). > That is wrong since resources are left undeallocated.

[PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

2016-12-23 Thread Alexey Khoroshilov
During transition to using devm_input_allocate_device() goto to resource deallocation block was replaced by return in case of error in iio_device_register(). That is wrong since resources are left undeallocated. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey