Re: [PATCH] iio: temperature: ltc2983: fix leak of device node iterator

2020-09-26 Thread Jonathan Cameron
On Sat, 26 Sep 2020 16:45:56 +0200 Markus Elfring wrote: > > Thought about adding an "goto err_of_node_put" instead, but as the error > > paths are quite divergent, I'm not sure if that wouldn't complicate > > things. > > Please add jump targets like “e_inval” and “put_node” so that a bit of >

Re: [PATCH] iio: temperature: ltc2983: fix leak of device node iterator

2020-09-26 Thread Jonathan Cameron
On Sat, 26 Sep 2020 12:45:54 +0200 Tobias Jordan wrote: > Add missing of_node_put calls for the error paths of the > for_each_available_child_of_node loop in ltc2983_parse_dt. > > Thought about adding an "goto err_of_node_put" instead, but as the error > paths are quite divergent, I'm not sure i

[PATCH] iio: temperature: ltc2983: fix leak of device node iterator

2020-09-26 Thread Tobias Jordan
Add missing of_node_put calls for the error paths of the for_each_available_child_of_node loop in ltc2983_parse_dt. Thought about adding an "goto err_of_node_put" instead, but as the error paths are quite divergent, I'm not sure if that wouldn't complicate things. Fixes: f110f3188e56 ("iio: tempe