Re: [PATCH] ima: Fix sizeof mismatches

2020-10-13 Thread Colin Ian King
On 13/10/2020 17:17, Mimi Zohar wrote: > On Mon, 2020-10-12 at 19:10 +0100, Colin Ian King wrote: >> On 12/10/2020 19:06, Joe Perches wrote: >>> On Mon, 2020-10-12 at 13:51 -0400, Mimi Zohar wrote: On Wed, 2020-10-07 at 11:27 -0700, Joe Perches wrote: > On Wed, 2020-10-07 at 12:02 +0100,

Re: [PATCH] ima: Fix sizeof mismatches

2020-10-13 Thread Mimi Zohar
On Mon, 2020-10-12 at 19:10 +0100, Colin Ian King wrote: > On 12/10/2020 19:06, Joe Perches wrote: > > On Mon, 2020-10-12 at 13:51 -0400, Mimi Zohar wrote: > >> On Wed, 2020-10-07 at 11:27 -0700, Joe Perches wrote: > >>> On Wed, 2020-10-07 at 12:02 +0100, Colin King wrote: > An incorrect

Re: [PATCH] ima: Fix sizeof mismatches

2020-10-12 Thread Colin Ian King
On 12/10/2020 19:06, Joe Perches wrote: > On Mon, 2020-10-12 at 13:51 -0400, Mimi Zohar wrote: >> On Wed, 2020-10-07 at 11:27 -0700, Joe Perches wrote: >>> On Wed, 2020-10-07 at 12:02 +0100, Colin King wrote: An incorrect sizeof is being used, sizeof(*fields) is not correct, it should be

Re: [PATCH] ima: Fix sizeof mismatches

2020-10-12 Thread Joe Perches
On Mon, 2020-10-12 at 13:51 -0400, Mimi Zohar wrote: > On Wed, 2020-10-07 at 11:27 -0700, Joe Perches wrote: > > On Wed, 2020-10-07 at 12:02 +0100, Colin King wrote: > > > An incorrect sizeof is being used, sizeof(*fields) is not correct, > > > it should be sizeof(**fields). This is not causing a

Re: [PATCH] ima: Fix sizeof mismatches

2020-10-12 Thread Mimi Zohar
On Wed, 2020-10-07 at 11:27 -0700, Joe Perches wrote: > On Wed, 2020-10-07 at 12:02 +0100, Colin King wrote: > > An incorrect sizeof is being used, sizeof(*fields) is not correct, > > it should be sizeof(**fields). This is not causing a problem since > > the size of these is the same. Fix this in

Re: [PATCH] ima: Fix sizeof mismatches

2020-10-07 Thread Joe Perches
On Wed, 2020-10-07 at 12:02 +0100, Colin King wrote: > An incorrect sizeof is being used, sizeof(*fields) is not correct, > it should be sizeof(**fields). This is not causing a problem since > the size of these is the same. Fix this in the kmalloc_array and > memcpy calls. [] > diff --git

Re: [PATCH] ima: Fix sizeof mismatches

2020-10-07 Thread Jarkko Sakkinen
On Wed, Oct 07, 2020 at 12:02:43PM +0100, Colin King wrote: > From: Colin Ian King > > An incorrect sizeof is being used, sizeof(*fields) is not correct, > it should be sizeof(**fields). This is not causing a problem since > the size of these is the same. Fix this in the kmalloc_array and >

RE: [PATCH] ima: Fix sizeof mismatches

2020-10-07 Thread Roberto Sassu
> From: Colin King [mailto:colin.k...@canonical.com] > Sent: Wednesday, October 7, 2020 1:03 PM > From: Colin Ian King > > An incorrect sizeof is being used, sizeof(*fields) is not correct, > it should be sizeof(**fields). This is not causing a problem since > the size of these is the same. Fix

[PATCH] ima: Fix sizeof mismatches

2020-10-07 Thread Colin King
From: Colin Ian King An incorrect sizeof is being used, sizeof(*fields) is not correct, it should be sizeof(**fields). This is not causing a problem since the size of these is the same. Fix this in the kmalloc_array and memcpy calls. Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")