Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-30 Thread Chen Gang
On 07/01/2013 09:40 AM, Chen Gang wrote: > On 06/26/2013 06:22 PM, Chen Gang wrote: >> > On 06/26/2013 06:17 PM, Richard Weinberger wrote: >>> >> Am 26.06.2013 12:01, schrieb Chen Gang: > On 06/26/2013 05:48 PM, Geert Uytterhoeven wrote: >>> >> On Wed, Jun 26, 2013 at 11:38 AM, Ric

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-30 Thread Chen Gang
On 06/26/2013 06:22 PM, Chen Gang wrote: > On 06/26/2013 06:17 PM, Richard Weinberger wrote: >> Am 26.06.2013 12:01, schrieb Chen Gang: On 06/26/2013 05:48 PM, Geert Uytterhoeven wrote: >> On Wed, Jun 26, 2013 at 11:38 AM, Richard Weinberger >> wrote: >> Since the API its

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 06:17 PM, Richard Weinberger wrote: > Am 26.06.2013 12:01, schrieb Chen Gang: >> > On 06/26/2013 05:48 PM, Geert Uytterhoeven wrote: >>> >> On Wed, Jun 26, 2013 at 11:38 AM, Richard Weinberger >>> >> wrote: >>> >> Since the API itself already contents the meaning: "return NU

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Am 26.06.2013 12:01, schrieb Chen Gang: > On 06/26/2013 05:48 PM, Geert Uytterhoeven wrote: >> On Wed, Jun 26, 2013 at 11:38 AM, Richard Weinberger wrote: >> Since the API itself already contents the meaning: "return NULL means >> the arch has no related io memory", >> No, NULL means it co

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 05:48 PM, Geert Uytterhoeven wrote: > On Wed, Jun 26, 2013 at 11:38 AM, Richard Weinberger wrote: >>> >> Since the API itself already contents the meaning: "return NULL means >>> >> the arch has no related io memory", > No, NULL means it could not map the I/O memory. > "it could no

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 05:38 PM, Richard Weinberger wrote: > Am 26.06.2013 11:33, schrieb Chen Gang: >> > On 06/26/2013 05:03 PM, Richard Weinberger wrote: >>> >> Am 26.06.2013 10:58, schrieb Chen Gang: > On 06/26/2013 04:39 PM, Richard Weinberger wrote: >>>

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Geert Uytterhoeven
On Wed, Jun 26, 2013 at 11:38 AM, Richard Weinberger wrote: >> Since the API itself already contents the meaning: "return NULL means >> the arch has no related io memory", No, NULL means it could not map the I/O memory. >> Why not define a generic dummy one in "include/asm-generic/io.h" instead

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Am 26.06.2013 11:33, schrieb Chen Gang: > On 06/26/2013 05:03 PM, Richard Weinberger wrote: >> Am 26.06.2013 10:58, schrieb Chen Gang: On 06/26/2013 04:39 PM, Richard Weinberger wrote: >> The drivers internal code has already check the related >> return

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 05:03 PM, Richard Weinberger wrote: > Am 26.06.2013 10:58, schrieb Chen Gang: >> > On 06/26/2013 04:39 PM, Richard Weinberger wrote: >>> >> The drivers internal code has already check the related >>> >> return value, >>> >> so it is the

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Am 26.06.2013 10:58, schrieb Chen Gang: > On 06/26/2013 04:39 PM, Richard Weinberger wrote: >> The drivers internal code has already check the related return value, >> so it is the architecture's duty to 'tell' the driver whether support >> io memory (e.g. define ioremap, bu

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 04:39 PM, Richard Weinberger wrote: > The drivers internal code has already check the related return value, > so it is the architecture's duty to 'tell' the driver whether support > io memory (e.g. define ioremap, but return NULL). >>> >> It does so already

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Am 26.06.2013 10:34, schrieb Chen Gang: > On 06/26/2013 04:05 PM, Richard Weinberger wrote: diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h index d5afe96..e80331d 100644 --- a/include/asm-generic/io.h +++ b/include/asm-generic/io.h @@ -3

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 04:05 PM, Richard Weinberger wrote: >>> diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h >>> index d5afe96..e80331d 100644 >>> --- a/include/asm-generic/io.h >>> +++ b/include/asm-generic/io.h >>> @@ -303,10 +303,10 @@ static inline void *phys_

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Richard Weinberger
Hi! Am 26.06.2013 09:56, schrieb Chen Gang: > On 06/26/2013 02:54 PM, Richard Weinberger wrote: >> Hi! >> >> Am 26.06.2013 08:31, schrieb Chen Gang: >>> For "User Mode Linux", it may enable 'MMU', but not need implement >>> ioremap and iounmap, so "include/asm-generic/io.h" need notice this >>> ca

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 03:38 PM, Geert Uytterhoeven wrote: > On Wed, Jun 26, 2013 at 8:54 AM, Richard Weinberger wrote: >>> >> -#ifndef CONFIG_MMU >>> >> +#if !CONFIG_MMU || CONFIG_UML > FWIW, the above syntax is not correct, it should be > > #if !defined(CONFIG_MMU) || defined(CONFIG_UML) > Oh, really

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Chen Gang
On 06/26/2013 02:54 PM, Richard Weinberger wrote: > Hi! > > Am 26.06.2013 08:31, schrieb Chen Gang: >> For "User Mode Linux", it may enable 'MMU', but not need implement >> ioremap and iounmap, so "include/asm-generic/io.h" need notice this >> case to keep itself 'generic'. >> >> The related error

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-26 Thread Geert Uytterhoeven
On Wed, Jun 26, 2013 at 8:54 AM, Richard Weinberger wrote: >> -#ifndef CONFIG_MMU >> +#if !CONFIG_MMU || CONFIG_UML FWIW, the above syntax is not correct, it should be #if !defined(CONFIG_MMU) || defined(CONFIG_UML) > UML has no io memory but a MMU, so I'd argue that you better fix > drivers/p

Re: [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-25 Thread Richard Weinberger
Hi! Am 26.06.2013 08:31, schrieb Chen Gang: > For "User Mode Linux", it may enable 'MMU', but not need implement > ioremap and iounmap, so "include/asm-generic/io.h" need notice this > case to keep itself 'generic'. > > The related error (with allmodconfig, without pcap): > > CC [M] drivers

[PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU'

2013-06-25 Thread Chen Gang
For "User Mode Linux", it may enable 'MMU', but not need implement ioremap and iounmap, so "include/asm-generic/io.h" need notice this case to keep itself 'generic'. The related error (with allmodconfig, without pcap): CC [M] drivers/ptp/ptp_pch.o drivers/ptp/ptp_pch.c: In function ‘pch_re