Re: [PATCH] include/linux/module.h: mark init/cleanup_module aliases as __cold

2019-02-06 Thread Miguel Ojeda
On Wed, Feb 6, 2019 at 5:31 PM Miguel Ojeda wrote: > > On Mon, Feb 4, 2019 at 4:08 PM Jessica Yu wrote: > > > > IMHO I think annotating with __init is more straightforward, instead > > of cherry-picking attributes (we wouldn't know at first glance why the > > aliases are specifically annotated wi

Re: [PATCH] include/linux/module.h: mark init/cleanup_module aliases as __cold

2019-02-06 Thread Miguel Ojeda
On Mon, Feb 4, 2019 at 4:08 PM Jessica Yu wrote: > > IMHO I think annotating with __init is more straightforward, instead > of cherry-picking attributes (we wouldn't know at first glance why the > aliases are specifically annotated with __cold without looking at git > history). Plus the actual mod

Re: [PATCH] include/linux/module.h: mark init/cleanup_module aliases as __cold

2019-02-04 Thread Jessica Yu
+++ Miguel Ojeda [31/01/19 17:48 +0100]: Hi Jessica, On Thu, Jan 31, 2019 at 3:22 PM Jessica Yu wrote: Hi Miguel, sorry for the delay! No worries! :) The module init functions are only called once from do_init_module(). Does the __cold attribute just assume it is unlikely to be executed,

Re: [PATCH] include/linux/module.h: mark init/cleanup_module aliases as __cold

2019-01-31 Thread Miguel Ojeda
Hi Jessica, On Thu, Jan 31, 2019 at 3:22 PM Jessica Yu wrote: > > Hi Miguel, sorry for the delay! No worries! :) > The module init functions are only called once from do_init_module(). > Does the __cold attribute just assume it is unlikely to be executed, > or just that it is infrequently calle

Re: [PATCH] include/linux/module.h: mark init/cleanup_module aliases as __cold

2019-01-31 Thread Jessica Yu
+++ Miguel Ojeda [23/01/19 18:37 +0100]: The upcoming GCC 9 release adds the -Wmissing-attributes warnings (enabled by -Wall), which trigger for all the init/cleanup_module aliases in the kernel (defined by the module_init/exit macros), ending up being very noisy. These aliases point to the __in

Re: [PATCH] include/linux/module.h: mark init/cleanup_module aliases as __cold

2019-01-25 Thread Laura Abbott
On 1/23/19 9:37 AM, Miguel Ojeda wrote: The upcoming GCC 9 release adds the -Wmissing-attributes warnings (enabled by -Wall), which trigger for all the init/cleanup_module aliases in the kernel (defined by the module_init/exit macros), ending up being very noisy. These aliases point to the __ini

[PATCH] include/linux/module.h: mark init/cleanup_module aliases as __cold

2019-01-23 Thread Miguel Ojeda
The upcoming GCC 9 release adds the -Wmissing-attributes warnings (enabled by -Wall), which trigger for all the init/cleanup_module aliases in the kernel (defined by the module_init/exit macros), ending up being very noisy. These aliases point to the __init/__exit functions of a module, which are