Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Chen Gang
On 2013年03月26日 10:47, Nicolas Pitre wrote: > On Tue, 26 Mar 2013, Chen Gang wrote: > >> a hacker may find something "valuable" with the aid of compiler ;-) >> >> maybe, it is a patch which is too minor to apply. I can understand :-) > > You should send such patches to Jiri Kosina . >

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Nicolas Pitre
On Tue, 26 Mar 2013, Chen Gang wrote: > a hacker may find something "valuable" with the aid of compiler ;-) > > maybe, it is a patch which is too minor to apply. I can understand :-) You should send such patches to Jiri Kosina . Nicolas -- To unsubscribe from this list: send the line

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Chen Gang
On 2013年03月26日 09:48, Greg KH wrote: > On Tue, Mar 26, 2013 at 09:22:57AM +0800, Chen Gang wrote: >> On 2013年03月26日 07:32, Greg KH wrote: >>> On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: better to let 'inline' in front of 'void' >>> >>> Why? What does this fix? >>> >>>

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Greg KH
On Tue, Mar 26, 2013 at 09:22:57AM +0800, Chen Gang wrote: > On 2013年03月26日 07:32, Greg KH wrote: > > On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: > >> > >> better to let 'inline' in front of 'void' > > > > Why? What does this fix? > > > > > > > > when I am compiling with

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Chen Gang
On 2013年03月26日 07:32, Greg KH wrote: > On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: >> >> better to let 'inline' in front of 'void' > > Why? What does this fix? > > > when I am compiling with "EXTRA_FLAGS=-W", I get a warning: make V=1 EXTRA_CFLAGS=-W ARCH=arm

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Greg KH
On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: > > better to let 'inline' in front of 'void' Why? What does this fix? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Greg KH
On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: better to let 'inline' in front of 'void' Why? What does this fix? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Chen Gang
On 2013年03月26日 07:32, Greg KH wrote: On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: better to let 'inline' in front of 'void' Why? What does this fix? when I am compiling with EXTRA_FLAGS=-W, I get a warning: make V=1 EXTRA_CFLAGS=-W ARCH=arm randconfig make

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Greg KH
On Tue, Mar 26, 2013 at 09:22:57AM +0800, Chen Gang wrote: On 2013年03月26日 07:32, Greg KH wrote: On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: better to let 'inline' in front of 'void' Why? What does this fix? when I am compiling with EXTRA_FLAGS=-W, I get

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Chen Gang
On 2013年03月26日 09:48, Greg KH wrote: On Tue, Mar 26, 2013 at 09:22:57AM +0800, Chen Gang wrote: On 2013年03月26日 07:32, Greg KH wrote: On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: better to let 'inline' in front of 'void' Why? What does this fix? when I am compiling

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Nicolas Pitre
On Tue, 26 Mar 2013, Chen Gang wrote: a hacker may find something valuable with the aid of compiler ;-) maybe, it is a patch which is too minor to apply. I can understand :-) You should send such patches to Jiri Kosina triv...@kernel.org. Nicolas -- To unsubscribe from this list:

Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-25 Thread Chen Gang
On 2013年03月26日 10:47, Nicolas Pitre wrote: On Tue, 26 Mar 2013, Chen Gang wrote: a hacker may find something valuable with the aid of compiler ;-) maybe, it is a patch which is too minor to apply. I can understand :-) You should send such patches to Jiri Kosina triv...@kernel.org.

[PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-24 Thread Chen Gang
better to let 'inline' in front of 'void' Signed-off-by: Chen Gang --- include/linux/platform_data/usb-ohci-s3c2410.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/platform_data/usb-ohci-s3c2410.h b/include/linux/platform_data/usb-ohci-s3c2410.h

[PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

2013-03-24 Thread Chen Gang
better to let 'inline' in front of 'void' Signed-off-by: Chen Gang gang.c...@asianux.com --- include/linux/platform_data/usb-ohci-s3c2410.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/platform_data/usb-ohci-s3c2410.h