Re: [PATCH] init_module: update to modern interfaces

2012-10-17 Thread Rusty Russell
"Michael Kerrisk (man-pages)" writes: > Hi Rusty, > > Thanks for the review! One open question below. > > On Thu, Oct 11, 2012 at 4:50 AM, Rusty Russell wrote: >> "Michael Kerrisk (man-pages)" writes: >>> [CC widened, so that some more review might come in. Rusty?] >> >> Sure. >> >> Looks good.

Re: [PATCH] init_module: update to modern interfaces

2012-10-10 Thread Rusty Russell
"Michael Kerrisk (man-pages)" writes: > [CC widened, so that some more review might come in. Rusty?] Sure. Looks good. but: > .B EBUSY > The module's initialization routine failed. Possibly. You should mention that the individual module's initialization routine can return other errors as appr

Re: [PATCH] init_module: update to modern interfaces

2012-10-09 Thread Michael Kerrisk (man-pages)
[CC widened, so that some more review might come in. Rusty?] Hello Kees, Comments below. On Fri, Sep 21, 2012 at 1:27 AM, Kees Cook wrote: > This updates init_module(2) to reflect the reality of 2.6+ module > loading interfaces. It additionally drops references to the extra > deprecated module

[PATCH] init_module: update to modern interfaces

2012-09-20 Thread Kees Cook
This updates init_module(2) to reflect the reality of 2.6+ module loading interfaces. It additionally drops references to the extra deprecated module functions create_module(2) and query_module(2). Signed-off-by: Kees Cook --- man2/delete_module.2 |7 ++-- man2/init_module.2 | 90 +++