Re: [PATCH] input/misc/drv260x: Remove a useless comparison

2020-05-07 Thread Dmitry Torokhov
Hi, On Thu, May 07, 2020 at 01:16:17PM +0800, ChenTao wrote: > Fix the following warning: > > 'mode' and 'library' are u32, they are never be negative, > DRV260X_LRA_MODE and DRV260X_LIB_EMPTY are 0x00, the comparison > is always false. The fact that the symbolic names resolve to 0 is just a

[PATCH] input/misc/drv260x: Remove a useless comparison

2020-05-06 Thread ChenTao
Fix the following warning: 'mode' and 'library' are u32, they are never be negative, DRV260X_LRA_MODE and DRV260X_LIB_EMPTY are 0x00, the comparison is always false. drivers/input/misc/drv260x.c:478:20: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if