Re: [PATCH] input: psmouse: fix potential input register race in psmouse_connect()

2008-01-15 Thread Dmitry Torokhov
On Sat, Jan 12, 2008 at 03:13:45PM -0500, Andres Salomon wrote: > > If we successfully call input_register_device() in > psmouse_connect but sysfs_create_group() fails, we'll enter the error > path without ever having called input_unregister_device() (potentially > leaking memory, or creating a

Re: [PATCH] input: psmouse: fix potential input register race in psmouse_connect()

2008-01-15 Thread Dmitry Torokhov
On Sat, Jan 12, 2008 at 03:13:45PM -0500, Andres Salomon wrote: If we successfully call input_register_device() in psmouse_connect but sysfs_create_group() fails, we'll enter the error path without ever having called input_unregister_device() (potentially leaking memory, or creating a race

[PATCH] input: psmouse: fix potential input register race in psmouse_connect()

2008-01-12 Thread Andres Salomon
If we successfully call input_register_device() in psmouse_connect but sysfs_create_group() fails, we'll enter the error path without ever having called input_unregister_device() (potentially leaking memory, or creating a race condition if something else attempts to access the new input device).

[PATCH] input: psmouse: fix potential input register race in psmouse_connect()

2008-01-12 Thread Andres Salomon
If we successfully call input_register_device() in psmouse_connect but sysfs_create_group() fails, we'll enter the error path without ever having called input_unregister_device() (potentially leaking memory, or creating a race condition if something else attempts to access the new input device).