Re: [Linux-ima-user] oraphaned keywords in audit log text [was: Re: [PATCH] integrity: get comm using lock to avoid race in string] printing

2014-06-14 Thread Richard Guy Briggs
On 14/06/14, Mimi Zohar wrote: > On Sat, 2014-06-14 at 12:43 +0300, Dmitry Kasatkin wrote: > > On 14 June 2014 03:02, Richard Guy Briggs wrote: > > > On 14/04/02, Richard Guy Briggs wrote: > > >> On 14/04/02, Mimi Zohar wrote: > > >> > On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: > > >> >

Re: [Linux-ima-user] oraphaned keywords in audit log text [was: Re: [PATCH] integrity: get comm using lock to avoid race in string] printing

2014-06-14 Thread Mimi Zohar
On Sat, 2014-06-14 at 12:43 +0300, Dmitry Kasatkin wrote: > On 14 June 2014 03:02, Richard Guy Briggs wrote: > > On 14/04/02, Richard Guy Briggs wrote: > >> On 14/04/02, Mimi Zohar wrote: > >> > On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: > >> > > On Wed, 2014-04-02 at 14:12 -0400, Mimi

Re: [Linux-ima-user] oraphaned keywords in audit log text [was: Re: [PATCH] integrity: get comm using lock to avoid race in string] printing

2014-06-14 Thread Dmitry Kasatkin
On 14 June 2014 03:02, Richard Guy Briggs wrote: > On 14/04/02, Richard Guy Briggs wrote: >> On 14/04/02, Mimi Zohar wrote: >> > On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: >> > > On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: >> > > > On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb

Re: oraphaned keywords in audit log text [was: Re: [PATCH] integrity: get comm using lock to avoid race in string] printing

2014-06-13 Thread Richard Guy Briggs
On 14/04/02, Richard Guy Briggs wrote: > On 14/04/02, Mimi Zohar wrote: > > On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: > > > On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: > > > > On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: > > > > > Hello Mimi, > > > > > > > > > > On W

oraphaned keywords in audit log text [was: Re: [PATCH] integrity: get comm using lock to avoid race in string] printing

2014-04-02 Thread Richard Guy Briggs
On 14/04/02, Mimi Zohar wrote: > On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: > > On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: > > > On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: > > > > Hello Mimi, > > > > > > > > On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Richard Guy Briggs
On 14/04/02, Mimi Zohar wrote: > On Wed, 2014-04-02 at 12:19 -0400, Richard Guy Briggs wrote: > > When task->comm is passed directly to audit_log_untrustedstring() without > > getting a copy or using the task_lock, there is a race that could happen > > that > > would output a NULL (\0) in the out

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Mimi Zohar
On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: > On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: > > On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: > > > Hello Mimi, > > > > > > On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: > > > > This change is already being upst

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Eric Paris
On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: > On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: > > Hello Mimi, > > > > On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: > > > This change is already being upstreamed as commit 73a6b44 "Integrity: > > > Pass commname via get_t

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Mimi Zohar
On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: > Hello Mimi, > > On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: > > This change is already being upstreamed as commit 73a6b44 "Integrity: > > Pass commname via get_task_comm()". > > While I was looking at Richard's patch, I notic

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Steve Grubb
Hello Mimi, On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: > This change is already being upstreamed as commit 73a6b44 "Integrity: > Pass commname via get_task_comm()". While I was looking at Richard's patch, I noticed a few places where cause and op are logged and the string isn't t

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Mimi Zohar
On Wed, 2014-04-02 at 12:19 -0400, Richard Guy Briggs wrote: > When task->comm is passed directly to audit_log_untrustedstring() without > getting a copy or using the task_lock, there is a race that could happen that > would output a NULL (\0) in the output string that would effectively truncate >

[PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Richard Guy Briggs
When task->comm is passed directly to audit_log_untrustedstring() without getting a copy or using the task_lock, there is a race that could happen that would output a NULL (\0) in the output string that would effectively truncate the rest of the report text after the comm= field in the audit, losin