Re: [PATCH] intel-iommu: don't disable ATS for device without page aligned request

2020-09-13 Thread Jason Wang
On 2020/9/10 下午11:53, Raj, Ashok wrote: On Wed, Sep 09, 2020 at 10:17:35PM -0400, Jason Wang wrote: - Original Message - Hi Jason On Wed, Sep 09, 2020 at 04:34:32PM +0800, Jason Wang wrote: Commit 61363c1474b1 ("iommu/vt-d: Enable ATS only if the device uses page aligned

Re: [PATCH] intel-iommu: don't disable ATS for device without page aligned request

2020-09-09 Thread Jason Wang
- Original Message - > Hi Jason > > On Wed, Sep 09, 2020 at 04:34:32PM +0800, Jason Wang wrote: > > Commit 61363c1474b1 ("iommu/vt-d: Enable ATS only if the device uses > > page aligned address.") disables ATS for device that can do unaligned > > page request. > > Did you take a look

Re: [PATCH] intel-iommu: don't disable ATS for device without page aligned request

2020-09-09 Thread Raj, Ashok
Hi Jason On Wed, Sep 09, 2020 at 04:34:32PM +0800, Jason Wang wrote: > Commit 61363c1474b1 ("iommu/vt-d: Enable ATS only if the device uses > page aligned address.") disables ATS for device that can do unaligned > page request. Did you take a look at the PCI specification? Page Aligned Request

[PATCH] intel-iommu: don't disable ATS for device without page aligned request

2020-09-09 Thread Jason Wang
Commit 61363c1474b1 ("iommu/vt-d: Enable ATS only if the device uses page aligned address.") disables ATS for device that can do unaligned page request. This looks wrong, since the commit log said it's because the page request descriptor doesn't support reporting unaligned request. A victim is